Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128181 / 24.10 / Real-world testing fixes #74

Merged
merged 1 commit into from
Apr 3, 2024
Merged

NAS-128181 / 24.10 / Real-world testing fixes #74

merged 1 commit into from
Apr 3, 2024

Conversation

themylogin
Copy link
Contributor

No description provided.

@yocalebo yocalebo added the jira label Apr 3, 2024
@bugclerk bugclerk changed the title Real-world testing fixes NAS-128181 / 24.10 / Real-world testing fixes Apr 3, 2024
@bugclerk
Copy link

bugclerk commented Apr 3, 2024

@themylogin themylogin merged commit e5ebabf into master Apr 3, 2024
2 checks passed
@themylogin themylogin deleted the fix branch April 3, 2024 18:05
@bugclerk
Copy link

bugclerk commented Apr 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 3, 2024
@themylogin
Copy link
Contributor Author

time 0:10

@bugclerk
Copy link

bugclerk commented Apr 3, 2024

Time tracking failed:

  File "/home/bugclerk/bugclerk/__main__.py", line 1173, in track_time
    comment.create_reaction('+1')
  File "/home/bugclerk/venv/lib/python3.11/site-packages/github/IssueComment.py", line 160, in create_reaction
    headers, data = self._requester.requestJsonAndCheck(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/bugclerk/venv/lib/python3.11/site-packages/github/Requester.py", line 315, in requestJsonAndCheck
    return self.__check(
           ^^^^^^^^^^^^^
  File "/home/bugclerk/venv/lib/python3.11/site-packages/github/Requester.py", line 340, in __check
    raise self.__createException(status, responseHeaders, output)
github.GithubException.GithubException: 403 {"message": "Must have admin rights to Repository.", "documentation_url": "https://docs.github.com/rest/reactions/reactions#create-reaction-for-an-issue-comment"}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants