-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-133675 / 25.10 / Refactor CloudBackupListComponent to master-detail-view #11429
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11429 +/- ##
==========================================
- Coverage 83.25% 83.24% -0.01%
==========================================
Files 1652 1653 +1
Lines 58999 59003 +4
Branches 6323 6322 -1
==========================================
- Hits 49117 49115 -2
- Misses 9882 9888 +6 ☔ View full report in Codecov by Sentry. |
@AlexKarpov98 hold on with testing, I found multiple regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for regressions resolving
@AlexKarpov98 okay regressions are fixed. cloud list tests are not. may i ask you to take a fresh look on it and why rows are not there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine, but I Noticed few issues:
Cloud backup edition - does not update data in the table. (see name)
Screen.Recording.2025-02-07.at.14.28.18.mov
Cloud backup deletion - does not hide details.
Screen.Recording.2025-02-07.at.14.29.56.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good 👍
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133675 is targeted to the following versions which have not received their corresponding PRs: 25.04-RC.1 |
This PR has been merged and conversations have been locked. |
backport |
Changes:
Testing:
Check page at
/data-protection/cloud-backup
Downstream