Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133675 / 25.10 / Refactor CloudBackupListComponent to master-detail-view #11429

Merged
merged 15 commits into from
Feb 9, 2025

Conversation

denysbutenko
Copy link
Member

Changes:

  • Refactor CloudBackupListComponent to master-detail-view

Testing:

Check page at /data-protection/cloud-backup

Downstream

Affects Reasoning
Documentation refactoring, screenshot may need updated

@denysbutenko denysbutenko requested a review from a team as a code owner January 28, 2025 13:36
@denysbutenko denysbutenko requested review from AlexKarpov98 and removed request for a team January 28, 2025 13:36
@bugclerk bugclerk changed the title NAS-133675: Refactor CloudBackupListComponent to master-detail-view NAS-133675 / 25.10 / Refactor CloudBackupListComponent to master-detail-view Jan 28, 2025
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 16 lines in your changes missing coverage. Please review.

Project coverage is 83.24%. Comparing base (8c9931d) to head (be0d430).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/cloud-backup-list/cloud-backup-list.component.ts 65.38% 9 Missing ⚠️
...p/all-cloud-backups/all-cloud-backups.component.ts 89.47% 6 Missing ⚠️
...pp/pages/data-protection/data-protection.routes.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11429      +/-   ##
==========================================
- Coverage   83.25%   83.24%   -0.01%     
==========================================
  Files        1652     1653       +1     
  Lines       58999    59003       +4     
  Branches     6323     6322       -1     
==========================================
- Hits        49117    49115       -2     
- Misses       9882     9888       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denysbutenko
Copy link
Member Author

@AlexKarpov98 hold on with testing, I found multiple regressions.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for regressions resolving

@denysbutenko
Copy link
Member Author

@AlexKarpov98 okay regressions are fixed. cloud list tests are not. may i ask you to take a fresh look on it and why rows are not there?

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine, but I Noticed few issues:

Cloud backup edition - does not update data in the table. (see name)

Screen.Recording.2025-02-07.at.14.28.18.mov

Cloud backup deletion - does not hide details.

Screen.Recording.2025-02-07.at.14.29.56.mov

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good 👍

@denysbutenko denysbutenko merged commit fd36ee9 into master Feb 9, 2025
9 checks passed
@denysbutenko denysbutenko deleted the NAS-133675 branch February 9, 2025 19:40
@bugclerk
Copy link
Contributor

bugclerk commented Feb 9, 2025

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-133675 is targeted to the following versions which have not received their corresponding PRs: 25.04-RC.1

@bugclerk
Copy link
Contributor

bugclerk commented Feb 9, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 9, 2025
@denysbutenko denysbutenko added the backport-25.04-RC.1 Fangtooth RC1 label Feb 10, 2025
@denysbutenko
Copy link
Member Author

backport

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants