-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-133818 / 25.04-BETA.1 / Update system version utils for new naming (by denysbutenko) #11432
base: release/25.04-BETA.1
Are you sure you want to change the base?
Conversation
(cherry picked from commit d5f37b2)
0a61dd9
to
d2c844b
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## release/25.04-BETA.1 #11432 +/- ##
=======================================================
Coverage ? 59.88%
=======================================================
Files ? 1644
Lines ? 58607
Branches ? 6182
=======================================================
Hits ? 35099
Misses ? 23508
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ported.
Hold off on merging this for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to have the changes we discussed where:
- We remove overview header
- Add Edition row that says Community or Enterprise.
- Show something simple like 25.10.0 – Fangtooth in the Version string.
Caleb has also informed me that they want to change |
Aha! I did it in TrueNAS Brand PR. System Version was fixed to how it works before. There is also About dialog that display system version. Since they are both targeted BETA.1 - I will merge new logo first and then fix remaining things here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay, but let's update tests to actual string returned by middleware - something similar to 25.10.0-MASTER-20250205-024806
.
Automatic cherry-pick failed. Please resolve conflicts by running:
If the original PR was merged via a squash, you can just cherry-pick the squashed commit:
Changes:
Adapt utils to naming changes in system version.
Testing:
Check system info widgets.
Original PR: #11419
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133818