Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133869 / 25.10 / Fix return value of user.create and user.update #11474

Closed
wants to merge 1 commit into from

Conversation

bvasilenko
Copy link
Contributor

Summary

Adapted to changes in middleware: user.create and user.update requests now return an id instead of a User object.

Testing:

Please see ticket for replication steps and expected results

@bvasilenko bvasilenko added the backport-25.04-RC.1 Fangtooth RC1 label Feb 4, 2025
@bvasilenko bvasilenko requested a review from a team as a code owner February 4, 2025 04:42
@bvasilenko bvasilenko requested review from RehanY147 and removed request for a team February 4, 2025 04:42
@bugclerk bugclerk changed the title NAS-133869: Fix return value of user.create and user.update NAS-133869 / 25.10 / Fix return value of user.create and user.update Feb 4, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Feb 4, 2025

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (86f1468) to head (0e5beb9).
Report is 37 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11474      +/-   ##
==========================================
- Coverage   83.29%   83.20%   -0.09%     
==========================================
  Files        1677     1650      -27     
  Lines       60238    58876    -1362     
  Branches     6390     6282     -108     
==========================================
- Hits        50173    48990    -1183     
+ Misses      10065     9886     -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this error when I create a new user

image

@bvasilenko
Copy link
Contributor Author

the bug was fixed on middleware side and does not occur any more.

@bvasilenko bvasilenko closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-25.04-RC.1 Fangtooth RC1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants