Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133723 / 25.10 / Adds "Enable VLAN" checkbox and sends null when disabled #11495

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RehanY147
Copy link
Contributor

Changes:

Adds an "Enable VLAN" checkbox to the ipmi form. If the checkbox is unchecked, UI should send null value in the "vlan" field when calling middleware endpoint. When the checkbox is checked, the vlan id field is required.

Testing:

Check that vlan id is disabled, enabled and set correctly.

@RehanY147 RehanY147 requested a review from a team as a code owner February 5, 2025 22:49
@RehanY147 RehanY147 requested review from AlexKarpov98 and removed request for a team February 5, 2025 22:49
@bugclerk
Copy link
Contributor

bugclerk commented Feb 5, 2025

@bugclerk bugclerk changed the title NAS-133723: Adds "Enable VLAN" checkbox and sends null when disabled NAS-133723 / 25.10 / Adds "Enable VLAN" checkbox and sends null when disabled Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.24%. Comparing base (4a1c5e0) to head (abc18f6).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ponents/ipmi-card/ipmi-form/ipmi-form.component.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11495       +/-   ##
===========================================
- Coverage   83.24%   60.24%   -23.01%     
===========================================
  Files        1653     1653               
  Lines       59003    59004        +1     
  Branches     6322     6322               
===========================================
- Hits        49118    35547    -13571     
- Misses       9885    23457    +13572     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍
Screenshot 2025-02-07 at 14 55 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants