Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-134054 / 25.04-RC.1 / Table expandable row does not wrap buttons (by AlexKarpov98) #11508

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Feb 7, 2025

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x fb99a1a6229ea096c24c7b4527522c657f3ecaf5
git cherry-pick -x 2db2bfb05da5cc790aefa65a28580aa46cb94759

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x f90b82a416ce9038cdff17091d81227e6841c25e

Code review is enough.

Original PR: #11500
Jira URL: https://ixsystems.atlassian.net/browse/NAS-134054

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review February 7, 2025 11:24
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner February 7, 2025 11:24
@AlexKarpov98 AlexKarpov98 requested review from AlexKarpov98 and removed request for a team February 7, 2025 11:24
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) February 7, 2025 11:25
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/fangtooth@ab65a75). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11508   +/-   ##
===================================================
  Coverage                    ?   82.91%           
===================================================
  Files                       ?     1651           
  Lines                       ?    58883           
  Branches                    ?     6231           
===================================================
  Hits                        ?    48825           
  Misses                      ?    10058           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit 141bc6f into stable/fangtooth Feb 7, 2025
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-134054-25.04-RC.1 branch February 7, 2025 12:53
@bugclerk
Copy link
Contributor Author

bugclerk commented Feb 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants