Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133932 / 25.04-RC.1 / Ease of use improvements for ISO uploads (by bvasilenko) #11518

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Feb 7, 2025

Automatic cherry-pick failed. Please resolve conflicts by running:

git cherry-pick -x c0d119530cf8903f96e3387de6f5719e79cbeada
git cherry-pick -x e722a74c17a70415aedfeed0d527318b58a43e21

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~3
git cherry-pick -x 8c9931d8a46efbdd4f4c1e7f191bb1d322324355

Testing:

You'll find TODO list in the ticket.

Item 1:

See replication steps in the ticket. The problem was in the common component ix-file-input. I fixed it.

Item 2:

Replication steps:

  1. User click Select ISO button, which is initially empty
  2. User uploads .iso file
  3. User closes the Volumes modal window
  4. User clicks Select ISO button again
  5. User uploads exactly same .iso file

Expected result: front-end does pre-validation and shows message immediately, without uploading the file.

Item 3:

Expected result: reporting of the upload progress ration in percentage 0% ... 100%

Original PR: #11507
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133932

@undsoft undsoft marked this pull request as ready for review February 7, 2025 21:16
@undsoft undsoft requested a review from a team as a code owner February 7, 2025 21:16
@undsoft undsoft requested review from denysbutenko and removed request for a team February 7, 2025 21:16
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported

@undsoft undsoft enabled auto-merge (squash) February 7, 2025 21:24
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/fangtooth@312d788). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/services/upload.service.ts 69.23% 4 Missing ⚠️
...g/upload-iso-button/upload-iso-button.component.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11518   +/-   ##
===================================================
  Coverage                    ?   82.92%           
===================================================
  Files                       ?     1651           
  Lines                       ?    58897           
  Branches                    ?     6234           
===================================================
  Hits                        ?    48839           
  Misses                      ?    10058           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit cddc960 into stable/fangtooth Feb 7, 2025
11 checks passed
@undsoft undsoft deleted the NAS-133932-25.04-RC.1 branch February 7, 2025 22:08
@bugclerk
Copy link
Contributor Author

bugclerk commented Feb 7, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants