Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

chore: apply prettier to all files #3496

Open
wants to merge 5 commits into
base: prettier
Choose a base branch
from
Open

Conversation

davidmurdoch
Copy link
Member

@davidmurdoch davidmurdoch commented Aug 4, 2022

Before merge: requires #3494 to be merged to develop.

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm putting a lot of trust in you not sneaking in changes here, cause I'm not reviewing all 100 files.

@davidmurdoch
Copy link
Member Author

Hahaha @MicaiahReid maybe reviewers should run npx prettier --write . on develop themselves and then compare their changes to what is here (can be done via git diff your-local-version prettier-apply) . We should all get the same results and don't have to "trust" anyone. :-)

@jeffsmale90
Copy link
Contributor

Hahaha @MicaiahReid maybe reviewers should run npx prettier --write . on develop themselves and then compare their changes to what is here (can be done via git diff your-local-version prettier-apply) . We should all get the same results and don't have to "trust" anyone. :-)

Trustless PRs!

@davidmurdoch
Copy link
Member Author

I just discovered that tsconfig.json's prettification will be undone due to the link-ts-references script that runs on post install. I think we should add a fix for it to this PR.

Copy link
Contributor

@tenthirtyone tenthirtyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found one diff

| D // the expected type
| ((options?: S) => D); // a fn that takes in a serialized object and returns the type
type DefaultValue<D, S> = // A default value can be:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only difference I get when running prettier locally.

@davidmurdoch
Copy link
Member Author

I've add a prettier step to link-ts-references: dcce767

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c6c333
Status: ✅  Deploy successful!
Preview URL: https://9ce3f616.ganache.pages.dev
Branch Preview URL: https://prettier-apply.ganache.pages.dev

View logs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants