spinners: fix remove logic #4950
Conversation
There was a problem hiding this comment.
Works around a bug in the spinnies module where removal of the final spinner may cause the spinner text to not disappear and/or may cause the process to hang on termination due to an interval not being cleared.
That's quite the premise! This should probably link to the bug/issue described.
Prior to this change, if `remove` was called for an individual spinner, the spinner may not have been removed and the process wouldn't exit due to an interval not being cleared properly.
benjamincburns
force-pushed
the
spinners-fix-remove
branch
from
a88923e
to
4aab43d
Compare
No such issue exists, and I didn't bother to create one as I did reach out to the repo owner and offer to volunteer as a maintainer however, as it's a project that gets 100k+ weekly downloads and appears to see very few bug reports and/or pull requests. |
It's a better experience to ora, imo. If the author abandoned it, perhaps we can switch to a maintained fork, or fork our own. |
Works around a bug in the
spinniesmodule (jbcarpanelli/spinnies#34) where removal of the final spinner may cause the spinner text to not disappear and/or may cause the process to hang on termination due to an interval not being cleared.