-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
Before this can be brought out of draft status, I need to:
Now that I've had a green build, I'll preemptively push the updated |
490a3b6
to
e9bfba1
Compare
3ae4f19
to
96a2e05
Compare
96a2e05
to
21bc087
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly makes sense to me. Only one line I don't quite understand.
@@ -12,7 +12,7 @@ | |||
"bugs": { | |||
"url": "https://github.com/trufflesuite/truffle/issues" | |||
}, | |||
"version": "0.1.2", | |||
"version": "0.2.0-0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting, actually changing this in the PR itself... we haven't typically done this, but it might be a good idea for us to start!
@@ -45,55 +49,54 @@ export class Spinner { | |||
return; | |||
} | |||
spinnies.remove(this.name); | |||
spinnies.checkIfActiveSpinners(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, as someone not familiar with all the spinner changes, what's the significance of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line that was removed was a workaround for a known issue in the official spinnies
module. I fixed that issue in our fork, and removed the workaround.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug in question was: jbcarpanelli/spinnies#34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks!
spinnies
dependency with a truffle-maintained fork (@trufflesuite/spinnies
)remove
is called on an active spinner jbcarpanelli/spinnies#34 (fixed by Truffle improvements spinnies#1)warn
feature on@truffle/spinners