-
Notifications
You must be signed in to change notification settings - Fork 2.3k
deps: dedupe and lockbump ethers, ethereumjs, web3 #6192
Conversation
6420df4
to
0206a10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this without changing any package.json
s, huh? Wow! Well if the tests are passing, I guess it's OK!
(We've still got multiple versions of ethers despite this, right? I seem to recall certain packages were using distinct major versions...)
@haltman-at : Yup! This doesn't do any semver-violating changes so nothing changed there. FWIW there is sill |
0206a10
to
4372ee3
Compare
FYI just added on 4372ee3 which dedupes the remaining |
Yeah, I remember there being a reason why contract is still on v4, although I don't remember offhand what it is. OTOH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again!
PR description
Dedupes and performs lockfile bumps of packages in the
ethers
,ethereumjs
, andweb3
families.Note that this implies a major upgrade of transitive
bn.js
from v4 to v5.Related
Testing instructions
Documentation
doc-change-required
label to this PR if documentation updates are required.Breaking changes and new features
breaking-change
andnew-feature
labels for the appropriate packages.