Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update old references to the new organization #16

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

MicBun
Copy link
Contributor

@MicBun MicBun commented Nov 25, 2024

Description

Related Problem

resolves: #17
resolves: #20

How Has This Been Tested?

@MicBun
Copy link
Contributor Author

MicBun commented Nov 25, 2024

I am unable to assign myself and set labels, also no PR Time Tracker yet

@MicBun
Copy link
Contributor Author

MicBun commented Nov 25, 2024

@outerlook, I couldn't request a review here, the button is unclickable

outerlook
outerlook previously approved these changes Nov 25, 2024
Copy link
Collaborator

@outerlook outerlook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all right, but I found the node part of the new name a bit confusing. I get that:

  • truf-sdk-js wasn't chosen because it could be confusing with TRUF token?
  • truf-network-sdk-js could be too long
  • truf-node-sdk-js seems to be an SDK for truf nodes (operators, to manage, etc)

were there more considerations on this?

@MicBun
Copy link
Contributor Author

MicBun commented Nov 25, 2024

I previously considered using node because tsn is being renamed into truf-node so tsn-sdk became truf-node-sdk. Feel free to leave suggestion for better name, before we are going too deep. @outerlook

@MicBun MicBun dismissed outerlook’s stale review November 25, 2024 19:47

need some renaming

@MicBun MicBun marked this pull request as draft November 25, 2024 19:47
@MicBun MicBun self-assigned this Nov 25, 2024
@MicBun MicBun added the chore label Nov 25, 2024
@MicBun MicBun requested a review from outerlook November 26, 2024 04:51
@MicBun MicBun marked this pull request as ready for review November 26, 2024 04:51
@MicBun MicBun requested a review from a team November 26, 2024 04:52
Copy link

pr-time-tracker bot commented Nov 26, 2024

@outerlook
⚠️⚠️⚠️
You must submit the time spent on this PR.
⚠️⚠️⚠️

@MicBun MicBun merged commit c6ace1a into trufnetwork:main Nov 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants