error: creating a mutable reference to mutable static is discouraged --> hook/src/hooks/mod.rs:397:9 | 397 | CB.take(); | ^^^^^^^^^ mutable reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

error: creating a mutable reference to mutable static is discouraged --> hook/src/hooks/mod.rs:368:14 | 368 | (CB.as_mut().unwrap())(rip); | ^^^^^^^^^^^ mutable reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

error: creating a mutable reference to mutable static is discouraged --> hook/src/hooks/mod.rs:620:19 | 620 | drop(unsafe { LOG_GUARD.take() }); | ^^^^^^^^^^^^^^^^ mutable reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

error: creating a mutable reference to mutable static is discouraged --> hook/src/hooks/mod.rs:583:40 | 583 | save(&slot, std::mem::take(&mut OPS)); | ^^^^^^^^ mutable reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives help: use `&raw mut` instead to create a raw pointer | 583 | save(&slot, std::mem::take(&raw mut OPS)); | ~~~~~~~~

error: creating a mutable reference to mutable static is discouraged --> hook/src/hooks/mod.rs:579:13 | 579 | OPS.clear(); | ^^^^^^^^^^^ mutable reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

error: creating a shared reference to mutable static is discouraged --> hook/src/hooks/mod.rs:271:40 | 271 | let mut normalized_path = unsafe { SAVES_DIR.as_ref() }?.clone(); | ^^^^^^^^^^^^^^^^^^ shared reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives

error: creating a mutable reference to mutable static is discouraged --> hook/src/hooks/mod.rs:121:17 | 121 | / OPS.push(Op { 122 | | data: if count == 0 { 123 | | vec![] 124 | | } else { ... | 129 | | stack, 130 | | }); | |__________________^ mutable reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: mutable references to mutable statics are dangerous; it's undefined behavior if any other pointer to the static is used or if any other reference is created for the static while the mutable reference lives

error: creating a shared reference to mutable static is discouraged --> hook/src/lib.rs:129:14 | 129 | unsafe { GLOBALS.as_ref().unwrap() } | ^^^^^^^^^^^^^^^^ shared reference to mutable static | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/static-mut-references.html> = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives = note: `-D static-mut-refs` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(static_mut_refs)]`

error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> hook/src/hooks/mod.rs:480:5 | 480 | impl Into<Action<TreeSpan>> for TreeNode { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-D clippy::from-over-into` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::from_over_into)]` help: replace the `Into` implementation with `From<hooks::save::TreeNode>` | 480 ~ impl From<TreeNode> for Action<TreeSpan> { 481 ~ fn from(val: TreeNode) -> Self { 482 ~ match val { |

error: redundant closure --> hook/src/hooks/mod.rs:463:51 | 463 | base64::decode(base64.as_bytes()).map_err(|e| serde::de::Error::custom(e)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `serde::de::Error::custom` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `-D clippy::redundant-closure` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::redundant_closure)]`

error: manual `RangeInclusive::contains` implementation --> hook/src/hooks/mod.rs:110:24 | 110 | if ip >= 0x140000000 && ip <= 0x14f000000 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x140000000..=0x14f000000).contains(&ip)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains = note: `-D clippy::manual-range-contains` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::manual_range_contains)]`

error: function `deserialize` is never used --> hook/src/hooks/mod.rs:461:12 | 461 | pub fn deserialize<'de, D: Deserializer<'de>>(d: D) -> Result<Vec<u8>, D::Error> { | ^^^^^^^^^^^

error: function `main` is never used --> hook/src/hooks/mod.rs:401:8 | 401 | fn main() { | ^^^^

error: function `hook` is never used --> hook/src/hooks/mod.rs:378:19 | 378 | pub unsafe fn hook<C, F, R>( | ^^^^

error: static `CB` is never used --> hook/src/hooks/mod.rs:377:16 | 377 | static mut CB: Option<Box<dyn FnMut(u64) -> ()>> = None; | ^^

error: function `exception_handler` is never used --> hook/src/hooks/mod.rs:359:35 | 359 | pub unsafe extern "system" fn exception_handler( | ^^^^^^^^^^^^^^^^^

error: function `remove_hardware_breakpoint` is never used --> hook/src/hooks/mod.rs:343:19 | 343 | pub unsafe fn remove_hardware_breakpoint() -> Result<(), Box<dyn std::error::Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^

error: function `set_hardware_breakpoint` is never used --> hook/src/hooks/mod.rs:324:19 | 324 | pub unsafe fn set_hardware_breakpoint( | ^^^^^^^^^^^^^^^^^^^^^^^

error: constant `HW_BREAKPOINT_TYPE_WRITE` is never used --> hook/src/hooks/mod.rs:322:11 | 322 | const HW_BREAKPOINT_TYPE_WRITE: u64 = 0b01; | ^^^^^^^^^^^^^^^^^^^^^^^^

error: constant `HW_BREAKPOINT_LEN_1` is never used --> hook/src/hooks/mod.rs:321:11 | 321 | const HW_BREAKPOINT_LEN_1: u64 = 0b00; | ^^^^^^^^^^^^^^^^^^^

error: variant `Seek` is never constructed --> hook/src/hooks/mod.rs:443:5 | 441 | pub enum Action<S> { | ------ variant in this enum 442 | Read(usize), 443 | Seek(usize), | ^^^^ | = note: `Action` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]`

error: use of deprecated function `base64::decode`: Use Engine::decode --> hook/src/hooks/mod.rs:463:17 | 463 | base64::decode(base64.as_bytes()).map_err(|e| serde::de::Error::custom(e)) | ^^^^^^

error: use of deprecated function `base64::encode`: Use Engine::encode --> hook/src/hooks/mod.rs:457:30 | 457 | let base64 = base64::encode(v); | ^^^^^^ | = note: `-D deprecated` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(deprecated)]`

error: unneeded unit return type --> hook/src/hooks/mod.rs:387:34 | 387 | let r: Box<dyn FnMut(u64) -> ()> = Box::new(cb); | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit

error: unneeded unit return type --> hook/src/hooks/mod.rs:384:22 | 384 | C: FnMut(u64) -> (), | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit

error: unneeded unit return type --> hook/src/hooks/mod.rs:377:45 | 377 | static mut CB: Option<Box<dyn FnMut(u64) -> ()>> = None; | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `-D clippy::unused-unit` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unused_unit)]`

error: unused imports: `HashMap` and `HashSet` --> hook/src/hooks/mod.rs:6:19 | 6 | collections::{HashMap, HashSet}, | ^^^^^^^ ^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]`

Clippy had exited with the 101 exit code

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/