error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:692:40 | 692 | fsd_pak_reader.get(&path, fsd_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:690:40 | 690 | fsd_pak_reader.get(&path, fsd_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:688:40 | 688 | mod_pak_reader.get(&path, mod_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:686:40 | 686 | mod_pak_reader.get(&path, mod_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

error: single-character string constant used as pattern --> src/integrate.rs:679:54 | 679 | if let Some((base, ext)) = lower.rsplit_once(".") { | ^^^ help: try using a `char` instead: `'.'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `-D clippy::single-char-pattern` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`

error: this let-binding has unit value --> src/gui/mod.rs:312:21 | 312 | let gameplay_affecting = {}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `{};` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `-D clippy::let-unit-value` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::let_unit_value)]`

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:692:40 | 692 | fsd_pak_reader.get(&path, fsd_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:690:40 | 690 | fsd_pak_reader.get(&path, fsd_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:688:40 | 688 | mod_pak_reader.get(&path, mod_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

error: this expression creates a reference which is immediately dereferenced by the compiler --> src/integrate.rs:686:40 | 686 | mod_pak_reader.get(&path, mod_pak)? | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`

error: single-character string constant used as pattern --> src/integrate.rs:679:54 | 679 | if let Some((base, ext)) = lower.rsplit_once(".") { | ^^^ help: try using a `char` instead: `'.'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `-D clippy::single-char-pattern` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::single_char_pattern)]`

error: field `0` is never read --> src/lib.rs:393:12 | 393 | NotPak(Box<dyn ReadSeek>), | ------ ^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 393 | NotPak(()), | ~~

error: this let-binding has unit value --> src/gui/mod.rs:312:21 | 312 | let gameplay_affecting = {}; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `{};` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `-D clippy::let-unit-value` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::let_unit_value)]`

error: field `0` is never read --> src/lib.rs:393:12 | 393 | NotPak(Box<dyn ReadSeek>), | ------ ^^^^^^^^^^^^^^^^^ | | | field in this variant | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 393 | NotPak(()), | ~~

error: unused variable: `gameplay_affecting` --> src/gui/mod.rs:312:25 | 312 | let gameplay_affecting = {}; | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_gameplay_affecting` | = note: `-D unused-variables` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_variables)]`

error: unused variable: `gameplay_affecting` --> src/gui/mod.rs:312:25 | 312 | let gameplay_affecting = {}; | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_gameplay_affecting` | = note: `-D unused-variables` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_variables)]`

error: this `if` statement can be collapsed --> src/integrate.rs:650:13 | 650 | / if base.outer_index.index == 0 && base.class_index.is_import() { 651 | | if !asset 652 | | .get_import(base.class_index) 653 | | .map(|import| import.object_name.get_content(|c| whitelist.contains(c))) ... | 658 | | }; 659 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `-D clippy::collapsible-if` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]` help: collapse nested if block | 650 ~ if base.outer_index.index == 0 && base.class_index.is_import() && !asset 651 + .get_import(base.class_index) 652 + .map(|import| import.object_name.get_content(|c| whitelist.contains(c))) 653 + .unwrap_or(false) { 654 + // invalid import or import name is not whitelisted, unknown 655 + return Ok(GameplayAffecting::Yes); 656 + } |

error: this `if` statement can be collapsed --> src/integrate.rs:650:13 | 650 | / if base.outer_index.index == 0 && base.class_index.is_import() { 651 | | if !asset 652 | | .get_import(base.class_index) 653 | | .map(|import| import.object_name.get_content(|c| whitelist.contains(c))) ... | 658 | | }; 659 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `-D clippy::collapsible-if` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]` help: collapse nested if block | 650 ~ if base.outer_index.index == 0 && base.class_index.is_import() && !asset 651 + .get_import(base.class_index) 652 + .map(|import| import.object_name.get_content(|c| whitelist.contains(c))) 653 + .unwrap_or(false) { 654 + // invalid import or import name is not whitelisted, unknown 655 + return Ok(GameplayAffecting::Yes); 656 + } |

Clippy had exited with the 101 exit code

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.