Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-verification #124

Closed
wants to merge 2 commits into from
Closed

Auto-verification #124

wants to merge 2 commits into from

Conversation

jieyouxu
Copy link
Collaborator

@jieyouxu jieyouxu commented Feb 1, 2024

NOTE: this branch is rebased off of native-bpl

Screenshot 2024-02-04 at 17 45 00 Screenshot 2024-02-04 at 17 45 06

Known bugs (pending fix):

  • Improper clearing of gameplay_affecting in GUI
  • Scroll bar on the right can overlap with auto-verification status badges.

Still need to:

  • Implement interaction with [MODDED] tag in hook.
  • Implement caching.

@jieyouxu jieyouxu changed the title [WIP] Auto-verification Auto-verification Feb 2, 2024
@jieyouxu jieyouxu marked this pull request as ready for review February 2, 2024 21:46
src/integrate.rs Outdated
Comment on lines 415 to 421
// HACK: if a url is like mod.io/mod-name#mod-id/mod-file-id we split right to get rid of
// the mod-file-id.
let resolution_hack = if let Some((left, _)) = mod_info.resolution.url.rsplit_once('/') {
ModResolution {
status: mod_info.resolution.status.clone(),
url: left.to_owned(),
}
} else {
mod_info.resolution.clone()
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this hack can go away if ModResolution is used as a key.

Nevermind, I see that ModResolution is not actually fully resolve (as in resolves to a URL with a specific modfile ID). Maybe it should be changed to do so? I will have to look further into this.

@trumank
Copy link
Owner

trumank commented Feb 4, 2024

I think this is good from a functionality standpoint now but needs some work on the GUI:

  • Merge the gameplay affecting tag with the existing Verified/Approved/Sandbox tags
  • Add an auto-verification lint that explains why a mod does or doesn't pass auto-verification
  • Add some indication of the overall approval status of the currently selected mod profile (maybe even add an approval status tag into the mod dropdown list?)

@jieyouxu

This comment was marked as resolved.

@Buckminsterfullerene02
Copy link
Contributor

I'm pretty sure Jonas said at one point ages ago (can't find the info now though) that he also blacklists anything inside the Game/_CustomSounds folder when auto-verifying to speed up the checking because most audio mods following my guide will use this folder as instructed. Probably doesn't matter anyway because rust fast, but worth mentioning in case you do need a performance uplift for large mod lists

@jieyouxu
Copy link
Collaborator Author

jieyouxu commented Mar 2, 2024

Closing this PR in favor of another one (this one has merge conflicts that was a pain to try to resolve).

@jieyouxu jieyouxu closed this Mar 2, 2024
@jieyouxu jieyouxu deleted the auto-verification branch March 2, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants