Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed mod info view #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add detailed mod info view #84

wants to merge 2 commits into from

Conversation

jieyouxu
Copy link
Collaborator

@jieyouxu jieyouxu commented Aug 21, 2023

Screenshot 2023-08-21 175451 Screenshot 2023-08-21 174831 Screenshot 2023-08-22 013756

Closes #83.

@jieyouxu jieyouxu force-pushed the detailed-mod-info branch 2 times, most recently from 96d9726 to a44abff Compare August 21, 2023 09:54
@trumank
Copy link
Owner

trumank commented Aug 21, 2023

Nice! Couple things:

  • Is it necessary to block interaction with the rest of the GUI when the details window is open? Changes to the profile don't invalidate any data displayed
  • Does the the window not play nicely with resizing? Would be nice if multiple detail windows could be opened simultaneously

@jieyouxu
Copy link
Collaborator Author

jieyouxu commented Aug 21, 2023

Nice! Couple things:

  • Is it necessary to block interaction with the rest of the GUI when the details window is open? Changes to the profile don't invalidate any data displayed
  • Does the the window not play nicely with resizing? Would be nice if multiple detail windows could be opened simultaneously

It's just that the current logic to handle the details window only correctly supports showing one mod detail at a time. EDIT: updated to support multiple mod detail windows.

@Buckminsterfullerene02
Copy link
Contributor

Buckminsterfullerene02 commented Aug 22, 2023

There is a major issue when resizing the details window as demonstrated in the video below:

2023-08-22.13-38-13.mp4

There is also a fair bit of lag when moving the window around, though it's quite a minor thing and I wouldn't at all be bothered if it cannot be fixed easily.

Furthermore, basic markdown support would be nice. I know it's not in egui but I found this extension crate for it that kind of does it. EDIT: I just tried adding it for the description text, and it doesn't handle quote text line feed so well, it actually looks worse than without. So probably needs some extra work than just plug n play, if it's even worth it, since they can just click on the mod link to view it properly in browser anyway...

@jieyouxu
Copy link
Collaborator Author

That looks like egui issue which I have no clue how to fix.

@trumank trumank force-pushed the detailed-mod-info branch from 0caf7eb to c926113 Compare August 31, 2023 05:52
@jieyouxu jieyouxu assigned jieyouxu and unassigned jieyouxu Mar 3, 2024
@jieyouxu jieyouxu added the S-blocked Status: blocked on something label Mar 3, 2024
@trumank trumank force-pushed the master branch 2 times, most recently from 9bc18cb to ad23a7b Compare April 23, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: blocked on something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View detailed mod info
3 participants