-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed mod info view #84
base: master
Are you sure you want to change the base?
Conversation
96d9726
to
a44abff
Compare
Nice! Couple things:
|
It's just that the current logic to handle the details window only correctly supports showing one mod detail at a time. EDIT: updated to support multiple mod detail windows. |
There is a major issue when resizing the details window as demonstrated in the video below: 2023-08-22.13-38-13.mp4There is also a fair bit of lag when moving the window around, though it's quite a minor thing and I wouldn't at all be bothered if it cannot be fixed easily. Furthermore, basic markdown support would be nice. I know it's not in egui but I found this extension crate for it that kind of does it. EDIT: I just tried adding it for the description text, and it doesn't handle quote text line feed so well, it actually looks worse than without. So probably needs some extra work than just plug n play, if it's even worth it, since they can just click on the mod link to view it properly in browser anyway... |
That looks like egui issue which I have no clue how to fix. |
0caf7eb
to
c926113
Compare
9bc18cb
to
ad23a7b
Compare
Closes #83.