Skip to content

Commit

Permalink
feat: upgrade to USWDS v3.1.0 (#2203)
Browse files Browse the repository at this point in the history
Upgrade to USWDS v3.1.0
  • Loading branch information
kleinschmidtj authored Oct 19, 2022
1 parent 1d9e977 commit cd40e03
Show file tree
Hide file tree
Showing 31 changed files with 333 additions and 321 deletions.
23 changes: 14 additions & 9 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,26 @@
const path = require('path')

const webpackConfig = (config) => {
config.resolve.alias.uswds = path.resolve(__dirname, '../node_modules/uswds')
config.resolve.alias.uswds = path.resolve(__dirname, '../node_modules/@uswds/uswds')

config.module.rules = config.module.rules.filter(
(rule) => rule.test.toString() !== '/\\.css$/'
)
config.module.rules.push({
test: /\.(sa|sc|c)ss$/,
exclude: /\.module\.(sa|sc|c)ss$/i,
use: ['style-loader', 'css-loader', 'sass-loader'],
use: ['style-loader', 'css-loader', {
loader: "sass-loader",
options: {
sourceMap: true,
sassOptions: {
includePaths: [
"./node_modules/@uswds",
"./node_modules/@uswds/uswds/packages",
],
},
},
},],
include: path.resolve(__dirname, '../'),
})

Expand All @@ -26,13 +37,7 @@ const webpackConfig = (config) => {
},
},
},
'sass-loader',
{
loader: 'sass-resources-loader',
options: {
resources: ['./src/uswdsResources.scss'],
},
},
"sass-loader",
],
})

Expand Down
2 changes: 1 addition & 1 deletion .storybook/preview.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import 'happo-plugin-storybook/register'

import 'uswds/dist/css/uswds.css'
import '@uswds/uswds/css/uswds.css'
import '../src/styles/index.scss'
import './custom-styles.scss'

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"peerDependencies": {
"react": "^16.x || ^17.x || ^18.x",
"react-dom": "^16.x || ^17.x || ^18.x",
"uswds": "2.13.3"
"@uswds/uswds": "3.1.0"
},
"devDependencies": {
"@babel/core": "^7.10.5",
Expand All @@ -74,6 +74,7 @@
"@types/react-test-renderer": "^18.0.0",
"@typescript-eslint/eslint-plugin": "^5.40.0",
"@typescript-eslint/parser": "^5.40.0",
"@uswds/uswds": "3.1.0",
"all-contributors-cli": "^6.24.0",
"@babel/eslint-parser": "^7.19.1",
"babel-jest": "^28.1.0",
Expand Down Expand Up @@ -119,7 +120,6 @@
"stylelint-scss": "^3.17.1",
"ts-jest": "^26.1.2",
"typescript": "^4.2.4",
"uswds": "2.13.3",
"webpack": "^5.52.1",
"webpack-cli": "^4.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/components/Footer/Footer/Footer.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { SocialLinks, SocialLink } from '../SocialLinks/SocialLinks'
import { TextInput } from '../../forms/TextInput/TextInput'

// assets
import logoImg from 'uswds/dist/img/logo-img.png'
import logoImg from '@uswds/uswds/img/logo-img.png'

export default {
title: 'Components/Footer',
Expand Down
2 changes: 1 addition & 1 deletion src/components/Footer/Logo/Logo.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React from 'react'
import { Logo } from './Logo'

// assets
import logoImg from 'uswds/src/img/logo-img.png'
import logoImg from '@uswds/uswds/src/img/logo-img.png'

export default {
title: 'Components/Footer/Logo',
Expand Down
10 changes: 5 additions & 5 deletions src/components/Footer/SocialLinks/SocialLinks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
import React from 'react'
import classnames from 'classnames'

import iconFacebook from 'uswds/src/img/usa-icons/facebook.svg'
import iconTwitter from 'uswds/src/img/usa-icons/twitter.svg'
import iconYouTube from 'uswds/src/img/usa-icons/youtube.svg'
import iconInstagram from 'uswds/src/img/usa-icons/instagram.svg'
import iconRSS from 'uswds/src/img/usa-icons/rss_feed.svg'
import iconFacebook from '@uswds/uswds/src/img/usa-icons/facebook.svg'
import iconTwitter from '@uswds/uswds/src/img/usa-icons/twitter.svg'
import iconYouTube from '@uswds/uswds/src/img/usa-icons/youtube.svg'
import iconInstagram from '@uswds/uswds/src/img/usa-icons/instagram.svg'
import iconRSS from '@uswds/uswds/src/img/usa-icons/rss_feed.svg'

type SocialLinksProps = {
links: React.ReactNode[]
Expand Down
478 changes: 239 additions & 239 deletions src/components/Icon/Icons.ts

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { IdentifierLogos } from '../IdentifierLogos/IdentifierLogos'

import { Link } from '../../Link/Link'

import dotGovIcon from 'uswds/src/img/icon-dot-gov.svg'
import dotGovIcon from '@uswds/uswds/src/img/icon-dot-gov.svg'

export default {
title: 'Components/Identifier',
Expand Down
2 changes: 1 addition & 1 deletion src/components/Identifier/Identifier/Identifier.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { IdentifierLinkItem } from '../IdentifierLinkItem/IdentifierLinkItem'
import { IdentifierGov } from '../IdentifierGov/IdentifierGov'
import { Link } from '../../Link/Link'

import dotGovIcon from 'uswds/src/img/icon-dot-gov.svg'
import dotGovIcon from '@uswds/uswds/src/img/icon-dot-gov.svg'

const testIdentifierLogo = (
<img
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import { render } from '@testing-library/react'

import dotGovIcon from 'uswds/src/img/icon-dot-gov.svg'
import dotGovIcon from '@uswds/uswds/src/img/icon-dot-gov.svg'

import { IdentifierLogo } from './IdentifierLogo'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React from 'react'
import { render } from '@testing-library/react'
import { IdentifierLogos } from './IdentifierLogos'

import dotGovIcon from 'uswds/src/img/icon-dot-gov.svg'
import dotGovIcon from '@uswds/uswds/src/img/icon-dot-gov.svg'

const testIdentifierLogo = (
<img
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import { render } from '@testing-library/react'

import dotGovIcon from 'uswds/src/img/icon-dot-gov.svg'
import dotGovIcon from '@uswds/uswds/src/img/icon-dot-gov.svg'

import { IdentifierMasthead } from './IdentifierMasthead'
import { IdentifierLogo } from '../IdentifierLogo/IdentifierLogo'
Expand Down
2 changes: 1 addition & 1 deletion src/components/Search/Search.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import classnames from 'classnames'

import searchImg from 'uswds/src/img/usa-icons-bg/search--white.svg'
import searchImg from '@uswds/uswds/src/img/usa-icons-bg/search--white.svg'

import { Button } from '../Button/Button'
import { Form, OptionalFormProps } from '../forms/Form/Form'
Expand Down
6 changes: 3 additions & 3 deletions src/components/banner/CustomBanner.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import {
MediaBlockBody,
} from '../../index'

import flagImg from 'uswds/src/img/us_flag_small.png'
import dotGovIcon from 'uswds/src/img/icon-dot-gov.svg'
import httpsIcon from 'uswds/src/img/icon-https.svg'
import flagImg from '@uswds/uswds/src/img/us_flag_small.png'
import dotGovIcon from '@uswds/uswds/src/img/icon-dot-gov.svg'
import httpsIcon from '@uswds/uswds/src/img/icon-https.svg'

const CustomBanner = (): ReactElement => {
const [isOpen, setIsOpen] = useState(false)
Expand Down
6 changes: 3 additions & 3 deletions src/components/banner/GovBanner/GovBanner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ import { MediaBlockBody } from '../../mediablock/MediaBlockBody/MediaBlockBody'
import { BannerLockImage } from '../BannerLockImage/BannerLockImage'

// assets
import flagImg from 'uswds/src/img/us_flag_small.png'
import dotGovIcon from 'uswds/src/img/icon-dot-gov.svg'
import httpsIcon from 'uswds/src/img/icon-https.svg'
import flagImg from '@uswds/uswds/src/img/us_flag_small.png'
import dotGovIcon from '@uswds/uswds/src/img/icon-dot-gov.svg'
import httpsIcon from '@uswds/uswds/src/img/icon-https.svg'

type Language = 'english' | 'spanish'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,27 +65,27 @@ export const BreadcrumbWithRdfaMetadata = (): React.ReactElement => {
<BreadcrumbBar listProps={{ ...rdfaMetadata.ol }}>
<Breadcrumb {...rdfaMetadata.li}>
<BreadcrumbLink href="#" {...rdfaMetadata.a}>
{/* eslint-disable-next-line react/no-unknown-property */ }
{/* eslint-disable-next-line react/no-unknown-property */}
<span property="name">Home</span>
</BreadcrumbLink>
<meta property="position" content="1" />
</Breadcrumb>
<Breadcrumb {...rdfaMetadata.li}>
<BreadcrumbLink href="#" {...rdfaMetadata.a}>
{/* eslint-disable-next-line react/no-unknown-property */ }
{/* eslint-disable-next-line react/no-unknown-property */}
<span property="name">Federal Contracting</span>
</BreadcrumbLink>
<meta property="position" content="2" />
</Breadcrumb>
<Breadcrumb {...rdfaMetadata.li}>
<BreadcrumbLink href="#" {...rdfaMetadata.a}>
{/* eslint-disable-next-line react/no-unknown-property */ }
{/* eslint-disable-next-line react/no-unknown-property */}
<span property="name">Contracting assistance programs</span>
</BreadcrumbLink>
<meta property="position" content="3" />
</Breadcrumb>
<Breadcrumb current {...rdfaMetadata.li}>
{/* eslint-disable-next-line react/no-unknown-property */ }
{/* eslint-disable-next-line react/no-unknown-property */}
<span property="name">
Women-owned small business federal contracting program
</span>
Expand Down
2 changes: 1 addition & 1 deletion src/components/header/NavCloseButton/NavCloseButton.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'
import classnames from 'classnames'
// assets
import closeImg from 'uswds/src/img/close.svg'
import closeImg from '@uswds/uswds/src/img/usa-icons/close.svg'

export const NavCloseButton = ({
onClick,
Expand Down
4 changes: 2 additions & 2 deletions src/stories/templates/createaccount.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ import {
IdentifierGov,
} from '../../index'

import logoImg from 'uswds/src/img/logo-img.png'
import circleSvg from 'uswds/src/img/circle-gray-20.svg'
import logoImg from '@uswds/uswds/src/img/logo-img.png'
import circleSvg from '@uswds/uswds/src/img/circle-gray-20.svg'
import { MediaBlockBody } from '../../components/mediablock/MediaBlockBody/MediaBlockBody'

export default {
Expand Down
2 changes: 1 addition & 1 deletion src/stories/templates/documentation.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable jsx-a11y/anchor-is-valid */
import React, { useState } from 'react'
import logoImg from 'uswds/src/img/logo-img.png'
import logoImg from '@uswds/uswds/src/img/logo-img.png'

import { GovBanner, GridContainer, Grid } from '../../index'

Expand Down
4 changes: 2 additions & 2 deletions src/stories/templates/landing.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable jsx-a11y/anchor-is-valid */
import React, { useState } from 'react'
import logoImg from 'uswds/src/img/logo-img.png'
import circleImg from 'uswds/src/img/circle-124.png'
import logoImg from '@uswds/uswds/src/img/logo-img.png'
import circleImg from '@uswds/uswds/src/img/circle-124.png'

import { GovBanner, GridContainer, Grid, MediaBlockBody } from '../../index'

Expand Down
4 changes: 2 additions & 2 deletions src/stories/templates/mutliplesignin.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ import {
Button,
} from '../../index'

import logoImg from 'uswds/src/img/logo-img.png'
import circleSvg from 'uswds/src/img/circle-gray-20.svg'
import logoImg from '@uswds/uswds/src/img/logo-img.png'
import circleSvg from '@uswds/uswds/src/img/circle-gray-20.svg'

export default {
title: 'Page Templates/Authentication Pages',
Expand Down
4 changes: 2 additions & 2 deletions src/stories/templates/notfound.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable jsx-a11y/anchor-is-valid */
import React, { useState } from 'react'
import logoImg from 'uswds/src/img/logo-img.png'
import circleSvg from 'uswds/src/img/circle-gray-20.svg'
import logoImg from '@uswds/uswds/src/img/logo-img.png'
import circleSvg from '@uswds/uswds/src/img/circle-gray-20.svg'

import {
GovBanner,
Expand Down
4 changes: 2 additions & 2 deletions src/stories/templates/signin.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import {
Button,
} from '../../index'

import logoImg from 'uswds/src/img/logo-img.png'
import circleSvg from 'uswds/src/img/circle-gray-20.svg'
import logoImg from '@uswds/uswds/src/img/logo-img.png'
import circleSvg from '@uswds/uswds/src/img/circle-gray-20.svg'

export default {
title: 'Page Templates/Authentication Pages',
Expand Down
2 changes: 2 additions & 0 deletions src/styles/_backgrounds.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use 'uswds-core' as *;

.bg-info-lighter {
@include u-bg('info-lighter');
}
Expand Down
2 changes: 2 additions & 0 deletions src/styles/_type.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@use 'uswds-core' as *;

.text-info-lighter {
@include u-text('info-lighter');
}
Expand Down
6 changes: 6 additions & 0 deletions src/styles/_uswds-theme.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Custom theme settings/USWDS overrides go here
@use 'uswds-core' with (
$theme-image-path: '@uswds/uswds/img',
$theme-font-path: '@uswds/uswds/fonts',
$theme-show-notifications: false
);
7 changes: 4 additions & 3 deletions src/styles/index.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
@import '../uswdsResources';
@forward 'uswds-theme';
@forward 'uswds';

@import 'backgrounds';
@import 'type';
@forward 'backgrounds';
@forward 'type';

// This should be set by USWDS but isn't
// It can be removed when https://github.com/uswds/uswds/issues/4458 is fixed
Expand Down
2 changes: 1 addition & 1 deletion src/uswds.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
import 'uswds/dist/css/uswds.css'
import '@uswds/uswds/css/uswds.css'
11 changes: 0 additions & 11 deletions src/uswdsResources.scss

This file was deleted.

25 changes: 16 additions & 9 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ module.exports = {
resolve: {
extensions: ['.tsx', '.ts', '.jsx', '.js'],
alias: {
uswds: path.resolve(__dirname, './node_modules/uswds'),
uswds: path.resolve(__dirname, './node_modules/@uswds/uswds'),
},
},
module: {
Expand All @@ -62,19 +62,26 @@ module.exports = {
},
},
},
'sass-loader',
{
loader: 'sass-resources-loader',
options: {
resources: ['./src/uswdsResources.scss'],
},
},
'sass-loader'
],
},
{
test: /\.(sa|sc|c)ss$/i,
exclude: /\.module\.(sa|sc|c)ss$/i,
use: [MiniCssExtractPlugin.loader, 'css-loader', 'sass-loader'],
use: [MiniCssExtractPlugin.loader, 'css-loader',
{
loader: "sass-loader",
options: {
sourceMap: true,
sassOptions: {
includePaths: [
"./node_modules/@uswds",
"./node_modules/@uswds/uswds/packages",
],
},
},
},
],
},
{
test: /\.svg$/,
Expand Down
Loading

0 comments on commit cd40e03

Please sign in to comment.