Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Tooltip label to be a string or React component #2596

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

lpsinger
Copy link
Contributor

Summary

Allow tooltip labels to be a string or any React component.

Related Issues or PRs

How To Test

Screenshots (optional)

@lpsinger lpsinger requested a review from a user September 27, 2023 18:14
@lpsinger lpsinger requested a review from jcbcapps as a code owner September 27, 2023 18:14
@lpsinger lpsinger force-pushed the tooltip-label-component branch from 096aef4 to 588b9dc Compare September 29, 2023 15:44
@lpsinger lpsinger requested a review from a team as a code owner September 29, 2023 15:44
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change! I believe this keeps the change backwards compatible as well, so this won't need to involve making our next release a breaking release 👍🏻

@brandonlenz brandonlenz enabled auto-merge (squash) October 18, 2023 00:09
auto-merge was automatically disabled October 18, 2023 14:30

Base branch was modified

@brandonlenz brandonlenz enabled auto-merge (squash) October 20, 2023 16:07
@brandonlenz brandonlenz merged commit bc01008 into trussworks:main Oct 20, 2023
5 checks passed
@lpsinger lpsinger deleted the tooltip-label-component branch November 3, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants