chore: add admin group and design owners group #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gidjin I had to update the @trussworks/react-uswds-design-owners role to have write access to the repository, otherwise they are not considered valid codeowners. All should be good now! |
brandonlenz
approved these changes
Sep 28, 2023
Thank you for that I didn't realize that was missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
react-uswds-admingithub team as code owners to make that easier to manager. Also adds thereact-uswds-design-ownersteam as owners of the storybook files. This is to facilitate having a designer provide input on changes that affect the look and feel of a component.