Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require id or name on Textarea #2752

Closed

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Feb 9, 2024

These are optional properties for input elements. Just pass them through in inputProps.

Summary

Related Issues or PRs

How To Test

Screenshots (optional)

These are optional properties for input elements. Just pass them
through in inputProps.
@lpsinger lpsinger requested a review from a team as a code owner February 9, 2024 22:37
Copy link
Contributor

@werdnanoslen werdnanoslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lpsinger, we prefer to require props that are fundamental to the element (such as id and name for a form input), even if they aren't necessarily "required" HTML attributes.

If you have a pattern-level change in mind for all form components, including Textarea, I suggest starting a type: documentation Improvements or additions to documentation / type: question Request for clarification, documentation, more information on library usage, contribution, etc. issue and tagging @haworku who wrote that part of the docs to develop it.

@lpsinger lpsinger deleted the textarea-dont-require-id-or-name branch February 13, 2024 15:10
@lpsinger
Copy link
Contributor Author

Hi @lpsinger, we prefer to require props that are fundamental to the element (such as id and name for a form input), even if they aren't necessarily "required" HTML attributes.

If you have a pattern-level change in mind for all form components, including Textarea, I suggest starting a type: documentation Improvements or additions to documentation / type: question Request for clarification, documentation, more information on library usage, contribution, etc. issue and tagging @haworku who wrote that part of the docs to develop it.

See #2776.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants