Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to add tags and return role for AWS config #45

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Add an option to add tags and return role for AWS config #45

merged 3 commits into from
Mar 30, 2020

Conversation

smelchior
Copy link
Contributor

No description provided.

@esacteksab
Copy link
Contributor

If you run make pre_commit_tests it will update the README with the new variable and new output.

dynamike
dynamike suggested changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@dynamike dynamike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like you missed tagging on

@smelchior
Copy link
Contributor Author

sorry for the delay, i updated the PR now :)

@dynamike
Copy link
Contributor 

PASS
ok  	github.com/trussworks/terraform-aws-config/test	404.173s

@dynamike dynamike merged commit 09a8e0e into trussworks:master Mar 30, 2020
@smelchior
Copy link
Contributor Author

thanks for merging this :) Do you know when you will be able to cut a new release?

@esacteksab
Copy link
Contributor

thanks for merging this :) Do you know when you will be able to cut a new release?

Done! https://github.com/trussworks/terraform-aws-config/releases/tag/v2.5.1

@exequielrafaela exequielrafaela mentioned this pull request Mar 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynamike dynamike dynamike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smelchior @esacteksab @dynamike