feat(sdk): update credential issuer metadata (#762)

Signed-off-by: Andrii Holovko <[email protected]>
trustbloc · Mar 26, 2024 · 1a3bb62 · 1a3bb62
1 parent 6dd4279
commit 1a3bb62
Show file tree

Hide file tree

Showing 10 changed files with 46 additions and 30 deletions.
diff --git a/cmd/wallet-sdk-gomobile/display/testdata/issuer_metadata.json b/cmd/wallet-sdk-gomobile/display/testdata/issuer_metadata.json
@@ -94,7 +94,7 @@
       "cryptographic_binding_methods_supported": [
         "ion"
       ],
-      "cryptographic_suites_supported": [
+      "credential_signing_alg_values_supported": [
         "ECDSASecp256k1DER"
       ],
       "display": [

diff --git a/cmd/wallet-sdk-gomobile/openid4ci/testdata/sample_issuer_metadata.json b/cmd/wallet-sdk-gomobile/openid4ci/testdata/sample_issuer_metadata.json
@@ -44,12 +44,16 @@
       "cryptographic_binding_methods_supported": [
         "web"
       ],
-      "cryptographic_suites_supported": [
+      "credential_signing_alg_values_supported": [
         "ECDSAP256DER"
       ],
-      "proof_types": [
-        "jwt"
-      ]
+      "proof_types_supported": {
+        "jwt": {
+          "proof_signing_alg_values_supported": [
+            "ECDSAP256DER"
+          ]
+        }
+      }
     }
   },
   "credential_endpoint": "[SERVER_URL]/oidc/credential",

diff --git a/pkg/credentialschema/testdata/bank_issuer_metadata.json b/pkg/credentialschema/testdata/bank_issuer_metadata.json
@@ -83,7 +83,7 @@
       "cryptographic_binding_methods_supported": [
         "orb"
       ],
-      "cryptographic_suites_supported": [
+      "credential_signing_alg_values_supported": [
         "ECDSASecp256k1DER"
       ],
       "display": [

diff --git a/pkg/credentialschema/testdata/issuer_metadata.json b/pkg/credentialschema/testdata/issuer_metadata.json
@@ -96,7 +96,7 @@
       "cryptographic_binding_methods_supported": [
         "ion"
       ],
-      "cryptographic_suites_supported": [
+      "credential_signing_alg_values_supported": [
         "ECDSASecp256k1DER"
       ],
       "display": [

diff --git a/pkg/credentialschema/testdata/issuer_metadata_without_claims_display.json b/pkg/credentialschema/testdata/issuer_metadata_without_claims_display.json
@@ -27,7 +27,7 @@
       "cryptographic_binding_methods_supported": [
         "ion"
       ],
-      "cryptographic_suites_supported": [
+      "credential_signing_alg_values_supported": [
         "ECDSASecp256k1DER"
       ],
       "display": [

diff --git a/pkg/internal/issuermetadata/testdata/sample_issuer_metadata.json b/pkg/internal/issuermetadata/testdata/sample_issuer_metadata.json
@@ -17,7 +17,7 @@
       "cryptographic_binding_methods_supported": [
         "jwk"
       ],
-      "cryptographic_suites_supported": [
+      "credential_signing_alg_values_supported": [
         "ECDSAP256DER"
       ],
       "display": [

diff --git a/pkg/models/issuer/metadata.go b/pkg/models/issuer/metadata.go
@@ -101,9 +101,8 @@ type CredentialConfigurationSupported struct {
 	// who possesses the Credential.
 	CryptographicBindingMethodsSupported []string `json:"cryptographic_binding_methods_supported,omitempty"`
 
-	// Array of case-sensitive strings that identify the cryptographic suites
-	// that are supported for the cryptographic_binding_methods_supported.
-	CryptographicSuitesSupported []string `json:"cryptographic_suites_supported,omitempty"`
+	// Array of case-sensitive strings that identify the algorithms that the Issuer uses to sign the issued Credential.
+	CredentialSigningAlgValuesSupported []string `json:"credential_signing_alg_values_supported,omitempty"`
 
 	// An array of objects, where each object contains the display properties of the
 	// supported credential for a certain language.
@@ -120,9 +119,8 @@ type CredentialConfigurationSupported struct {
 	// Array of the claim name values that lists them in the order they should be displayed by the Wallet.
 	Order []string `json:"order,omitempty"`
 
-	// A JSON array of case-sensitive strings, each representing proof_type that the Credential Issuer supports.
-	// If omitted, the default value is jwt.
-	ProofTypes []string `json:"proof_types,omitempty"`
+	// Object that describes specifics of the key proof(s) that the Credential Issuer supports.
+	ProofTypesSupported map[string]ProofTypeSupported `json:"proof_types_supported,omitempty"`
 
 	// A JSON string identifying the scope value that this Credential Issuer supports for this particular credential.
 	Scope string `json:"scope,omitempty"`
@@ -175,6 +173,12 @@ type CredentialResponseEncryptionSupported struct {
 	EncryptionRequired bool `json:"encryption_required"`
 }
 
+// ProofTypeSupported contains metadata about the proof type that the Credential Issuer supports.
+type ProofTypeSupported struct {
+	// Array of case-sensitive strings that identify the algorithms that the Issuer supports for this proof type.
+	ProofSigningAlgValuesSupported []string `json:"proof_signing_alg_values_supported"`
+}
+
 // GetJWTKID returns the jwtKID field. This is exposed via this method instead of with an exported field because
 // the linter expects all exported fields to have JSON tags, but the jwtKID field is only intended for use internally
 // within Wallet-SDK.

diff --git a/pkg/openid4ci/issuerinitiatedinteraction_test.go b/pkg/openid4ci/issuerinitiatedinteraction_test.go
@@ -340,7 +340,7 @@ func TestNewIssuerInitiatedInteraction(t *testing.T) {
 			  "cryptographic_binding_methods_supported": [
 				"ion"
 			  ],
-			  "cryptographic_suites_supported": [
+			  "credential_signing_alg_values_supported": [
 				"ED25519"
 			  ],
 			  "display": [
@@ -357,9 +357,13 @@ func TestNewIssuerInitiatedInteraction(t *testing.T) {
 				}
 			  ],
 			  "format": "jwt_vc_json_unsupported",
-			  "proof_types": [
-				"jwt"
-			  ]
+			  "proof_types_supported": {
+				"jwt": {
+				  "proof_signing_alg_values_supported": [
+					"ED25519"
+				  ]
+				}
+			  }
 			}
 		  },
 		  "credential_endpoint": "[SERVER_URL]/oidc/credential",

diff --git a/pkg/openid4ci/testdata/sample_issuer_metadata.json b/pkg/openid4ci/testdata/sample_issuer_metadata.json
@@ -133,7 +133,7 @@
       "cryptographic_binding_methods_supported": [
         "ion"
       ],
-      "cryptographic_suites_supported": [
+      "credential_signing_alg_values_supported": [
         "ED25519"
       ],
       "display": [
@@ -152,9 +152,13 @@
       "doctype": "",
       "format": "jwt_vc_json",
       "order": null,
-      "proof_types": [
-        "jwt"
-      ],
+      "proof_types_supported": {
+        "jwt": {
+          "proof_signing_alg_values_supported": [
+            "ED25519"
+          ]
+        }
+      },
       "scope": "",
       "vct": ""
     }

diff --git a/test/integration/fixtures/profile/profiles.json b/test/integration/fixtures/profile/profiles.json
@@ -155,7 +155,7 @@
               "cryptographic_binding_methods_supported": [
                 "did"
               ],
-              "cryptographic_suites_supported": [
+              "credential_signing_alg_values_supported": [
                 "Ed25519Signature2018"
               ],
               "display": [
@@ -357,7 +357,7 @@
               "cryptographic_binding_methods_supported": [
                 "did"
               ],
-              "cryptographic_suites_supported": [
+              "credential_signing_alg_values_supported": [
                 "Ed25519Signature2018"
               ],
               "display": [
@@ -541,7 +541,7 @@
               "cryptographic_binding_methods_supported": [
                 "did"
               ],
-              "cryptographic_suites_supported": [
+              "credential_signing_alg_values_supported": [
                 "Ed25519Signature2018"
               ],
               "display": [
@@ -718,7 +718,7 @@
               "cryptographic_binding_methods_supported": [
                 "did"
               ],
-              "cryptographic_suites_supported": [
+              "credential_signing_alg_values_supported": [
                 "Ed25519Signature2018"
               ],
               "display": [
@@ -852,7 +852,7 @@
               "cryptographic_binding_methods_supported": [
                 "did"
               ],
-              "cryptographic_suites_supported": [
+              "credential_signing_alg_values_supported": [
                 "Ed25519Signature2018"
               ],
               "display": [
@@ -985,7 +985,7 @@
               "cryptographic_binding_methods_supported": [
                 "did"
               ],
-              "cryptographic_suites_supported": [
+              "credential_signing_alg_values_supported": [
                 "Ed25519Signature2018"
               ],
               "display": [
@@ -1132,7 +1132,7 @@
               "cryptographic_binding_methods_supported": [
                 "did"
               ],
-              "cryptographic_suites_supported": [
+              "credential_signing_alg_values_supported": [
                 "Ed25519Signature2018"
               ],
               "display": [