Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depollute rake global scope #7

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Depollute rake global scope #7

merged 1 commit into from
Dec 6, 2024

Conversation

andrepiske
Copy link
Collaborator

Defining funtions in rake tasks affects the global rake scope (!!!).

The changes in this PR is one way I found to avoid that pollution.

@andrepiske andrepiske requested a review from a team December 5, 2024 17:51
Copy link
Member

@mhfs mhfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@andrepiske andrepiske merged commit e331153 into main Dec 6, 2024
7 checks passed
@andrepiske andrepiske deleted the depollute-global-scope branch December 6, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants