-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: reduce calls to backend on vulnerabilities page (#272)
- Loading branch information
1 parent
15cb4e9
commit 9ecb9b1
Showing
7 changed files
with
167 additions
and
189 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import React from "react"; | ||
|
|
||
| import { Label } from "@patternfly/react-core"; | ||
|
|
||
| import { VulnerabilityStatus } from "@app/api/models"; | ||
|
|
||
| interface VulnerabilityStatusLabelProps { | ||
| value: VulnerabilityStatus; | ||
| } | ||
|
|
||
| export const VulnerabilityStatusLabel: React.FC< | ||
| VulnerabilityStatusLabelProps | ||
| > = ({ value }) => { | ||
| return ( | ||
| <Label> | ||
| {value.charAt(0).toUpperCase() + value.slice(1).replace("_", " ")} | ||
| </Label> | ||
| ); | ||
| }; |
208 changes: 97 additions & 111 deletions
208
client/src/app/hooks/domain-controls/useSbomsOfVulnerability.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,141 +1,127 @@ | ||
| import React from "react"; | ||
|
|
||
| import { VulnerabilityStatus } from "@app/api/models"; | ||
| import { client } from "@app/axios-config/apiInit"; | ||
| import { | ||
| getSbom, | ||
| SbomSummary, | ||
| VulnerabilityAdvisorySummary, | ||
| } from "@app/client"; | ||
| import { SbomHead, VulnerabilityAdvisorySummary } from "@app/client"; | ||
| import { useFetchVulnerabilityById } from "@app/queries/vulnerabilities"; | ||
|
|
||
| interface SbomOfVulnerability { | ||
| sbomId: string; | ||
| const areSbomOfVulnerabilityEqual = ( | ||
| a: SbomOfVulnerability, | ||
| b: SbomOfVulnerability | FlatSbomOfVulnerability | ||
| ) => { | ||
| return a.sbom.id === b.sbom.id && a.sbomStatus === b.sbomStatus; | ||
| }; | ||
|
|
||
| interface FlatSbomOfVulnerability { | ||
| sbom: SbomHead & { version: string | null }; | ||
| sbomStatus: VulnerabilityStatus; | ||
| advisory: VulnerabilityAdvisorySummary; | ||
| status: VulnerabilityStatus; | ||
| sbom?: SbomSummary; | ||
| } | ||
|
|
||
| interface SbomOfVulnerability { | ||
| sbom: SbomHead & { version: string | null }; | ||
| sbomStatus: VulnerabilityStatus; | ||
| relatedPackages: { | ||
| advisory: VulnerabilityAdvisorySummary; | ||
| }[]; | ||
| } | ||
|
|
||
| export interface SbomOfVulnerabilitySummary { | ||
| total: number; | ||
| status: { [key in VulnerabilityStatus]: number }; | ||
| sbomStatus: { [key in VulnerabilityStatus]: number }; | ||
| } | ||
|
|
||
| const DEFAULT_SUMMARY: SbomOfVulnerabilitySummary = { | ||
| total: 0, | ||
| status: { affected: 0, fixed: 0, known_not_affected: 0, not_affected: 0 }, | ||
| sbomStatus: { affected: 0, fixed: 0, known_not_affected: 0, not_affected: 0 }, | ||
| }; | ||
|
|
||
| export const useSbomsOfVulnerability = (sbomId: string) => { | ||
| const { | ||
| vulnerability, | ||
| isFetching: isFetchingAdvisories, | ||
| fetchError: fetchErrorAdvisories, | ||
| } = useFetchVulnerabilityById(sbomId); | ||
|
|
||
| const [allSboms, setAllSboms] = React.useState<SbomOfVulnerability[]>([]); | ||
| const [sbomsById, setSbomsById] = React.useState<Map<string, SbomSummary>>( | ||
| new Map() | ||
| ); | ||
| const [isFetchingSboms, setIsFetchingSboms] = React.useState(false); | ||
|
|
||
| React.useEffect(() => { | ||
| if (vulnerability?.advisories?.length === 0) { | ||
| return; | ||
| } | ||
|
|
||
| const sboms = (vulnerability?.advisories ?? []) | ||
| .flatMap((advisory) => { | ||
| return (advisory.sboms ?? []).flatMap((sbom) => { | ||
| return sbom.status.map((status) => { | ||
| const result: SbomOfVulnerability = { | ||
| sbomId: sbom.id, | ||
| status: status as VulnerabilityStatus, | ||
| advisory: { ...advisory }, | ||
| const advisoryToModels = (advisories: VulnerabilityAdvisorySummary[]) => { | ||
| const sboms = advisories.flatMap((advisory) => { | ||
| return ( | ||
| (advisory.sboms ?? []) | ||
| .flatMap((sbomStatuses) => { | ||
| return sbomStatuses.status.map((sbomStatus) => { | ||
| const result: FlatSbomOfVulnerability = { | ||
| sbom: { | ||
| ...sbomStatuses, | ||
| version: sbomStatuses.version || null, | ||
| }, | ||
| sbomStatus: sbomStatus as VulnerabilityStatus, | ||
| advisory: advisory, | ||
| }; | ||
| return result; | ||
| }); | ||
| }); | ||
| }) | ||
| // Remove duplicates if exists | ||
| .reduce((prev, current) => { | ||
| const exists = prev.find( | ||
| (item) => | ||
| item.sbomId === current.sbomId && | ||
| item.advisory.uuid === current.advisory.uuid | ||
| ); | ||
| if (!exists) { | ||
| return [...prev, current]; | ||
| } else { | ||
| return prev; | ||
| } | ||
| }, [] as SbomOfVulnerability[]); | ||
|
|
||
| setAllSboms(sboms); | ||
| setIsFetchingSboms(true); | ||
|
|
||
| Promise.all( | ||
| sboms | ||
| .map(async (item) => { | ||
| const response = await getSbom({ | ||
| client, | ||
| path: { id: item.sbomId }, | ||
| }); | ||
| return response.data; | ||
| }) | ||
| .map((sbom) => sbom.catch(() => null)) | ||
| ).then((sboms) => { | ||
| const validSboms = sboms.reduce((prev, current) => { | ||
| if (current) { | ||
| return [...prev, current]; | ||
| } else { | ||
| // Filter out error responses | ||
| return prev; | ||
| } | ||
| }, [] as SbomSummary[]); | ||
| // group | ||
| .reduce((prev, current) => { | ||
| const existingElement = prev.find((item) => { | ||
| return areSbomOfVulnerabilityEqual(item, current); | ||
| }); | ||
|
|
||
| const sbomsById = new Map<string, SbomSummary>(); | ||
| validSboms.forEach((sbom) => sbomsById.set(sbom.id, sbom)); | ||
| if (existingElement) { | ||
| const arrayWithoutExistingItem = prev.filter( | ||
| (item) => !areSbomOfVulnerabilityEqual(item, existingElement) | ||
| ); | ||
|
|
||
| const updatedItemInArray: SbomOfVulnerability = { | ||
| ...existingElement, | ||
| relatedPackages: [ | ||
| ...existingElement.relatedPackages, | ||
| { | ||
| advisory: current.advisory, | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
| setSbomsById(sbomsById); | ||
| setIsFetchingSboms(false); | ||
| }); | ||
| }, [vulnerability]); | ||
| return [...arrayWithoutExistingItem, updatedItemInArray]; | ||
| } else { | ||
| const newItemInArray: SbomOfVulnerability = { | ||
| sbom: current.sbom, | ||
| sbomStatus: current.sbomStatus, | ||
| relatedPackages: [ | ||
| { | ||
| advisory: current.advisory, | ||
| }, | ||
| ], | ||
| }; | ||
| return [...prev, newItemInArray]; | ||
| } | ||
| }, [] as SbomOfVulnerability[]) | ||
| ); | ||
| }); | ||
|
|
||
| const summary = sboms.reduce((prev, current) => { | ||
| const sbomStatus = current.sbomStatus; | ||
| return { | ||
| ...prev, | ||
| total: prev.total + 1, | ||
| sbomStatus: { | ||
| ...prev.sbomStatus, | ||
| [sbomStatus]: prev.sbomStatus[sbomStatus] + 1, | ||
| }, | ||
| }; | ||
| }, DEFAULT_SUMMARY); | ||
|
|
||
| const allSbomsWithMappedData = React.useMemo(() => { | ||
| return allSboms.map((item) => { | ||
| const result: SbomOfVulnerability = { | ||
| ...item, | ||
| sbom: sbomsById.get(item.sbomId), | ||
| }; | ||
| return result; | ||
| }); | ||
| }, [allSboms, sbomsById]); | ||
| return { | ||
| sboms, | ||
| summary, | ||
| }; | ||
| }; | ||
|
|
||
| // Summary | ||
| export const useSbomsOfVulnerability = (sbomId: string) => { | ||
| const { | ||
| vulnerability, | ||
| isFetching: isFetchingAdvisories, | ||
| fetchError: fetchErrorAdvisories, | ||
| } = useFetchVulnerabilityById(sbomId); | ||
|
|
||
| const sbomsSummary = React.useMemo(() => { | ||
| return allSbomsWithMappedData.reduce((prev, current) => { | ||
| if (current.status) { | ||
| const status = current.status; | ||
| return { | ||
| ...prev, | ||
| total: prev.total + 1, | ||
| status: { | ||
| ...prev.status, | ||
| [status]: prev.status[status] + 1, | ||
| }, | ||
| }; | ||
| } else { | ||
| return prev; | ||
| } | ||
| }, DEFAULT_SUMMARY); | ||
| }, [allSbomsWithMappedData]); | ||
| const result = React.useMemo(() => { | ||
| return advisoryToModels(vulnerability?.advisories || []); | ||
| }, [vulnerability]); | ||
|
|
||
| return { | ||
| isFetching: isFetchingAdvisories || isFetchingSboms, | ||
| data: result, | ||
| isFetching: isFetchingAdvisories, | ||
| fetchError: fetchErrorAdvisories, | ||
| sboms: allSbomsWithMappedData, | ||
| summary: sbomsSummary, | ||
| }; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.