Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Search page #165

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Conversation

carlosthe19916
Copy link
Member

@carlosthe19916 carlosthe19916 commented Sep 26, 2024

Based on top of #163 . @kahboom I took your idea about using Contexts and hopefully this PR won't be a draft any longer once you come back.

Screencast.from.2024-09-26.17-59-36.mp4

With this PR we have the "Search Page" that embedded the "SBOM" + "Package" + "Vulnerability" page in a single one; while still be able to render each page separately and reuse all implementations done in each page.

  • The White Sidebar on the left of the table should contain all the filters that are yet to be fully defined as we won't necessarily copy and paste the filters available in V1. E

Once this PR is finished, reviewed, and merged it should allow us to divide tasks without too much collision between developers. And I am contemplating upcoming tasks (not to do in this PR but after this PR is merged):

  • SBOM List page compatibility with V1
  • Package List page compatibility with V1
  • Vulnerability List page compatibility with V1
  • Filtering implementation

@carlosthe19916 carlosthe19916 linked an issue Oct 1, 2024 that may be closed by this pull request
@carlosthe19916 carlosthe19916 merged commit bbb3aa6 into trustification:main Oct 2, 2024
7 checks passed
@carlosthe19916 carlosthe19916 deleted the search-page branch December 30, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Search Page Skeleton for V1 parity
2 participants