fix: css-minimizer-webpack-plugin updated to 7.0.0 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing this warning during npm install: ``` npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. ```
There was a problem hiding this comment.
Thanks for the PR!
This PR is upgrading major versions of one library and while it seems everything is working fine I would ask you to hold on please.
- I have created this issue Implement e2e tests #31 to put in place E2E tests in this repository so we are sure we do not break things on new PRs. I will work on it shortly
- Once the E2E tests are in place we can be more confident in doing this kind of things
- Upgrading dependencies is not a priority unless necessary, for now. Therefore, please I'd like to ask you for your patience until the e2e tests are in place and then we could merge this PR.
|
sounds good to me 👍 |
|
closing in the light of cleanup-repo-noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing this warning during npm install:
Related to #17