Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lower sqlx logging to "debug" #26

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Mar 8, 2024

The number of logs that sqlx creates is a bit too spammy for my taste, at least on the "info" level. I think it makes sense to keep them in general. Maybe even lower them to "trace".

@helio-frota
Copy link
Collaborator

helio-frota commented Mar 8, 2024

@ctron thanks for this

Related to #23 and #22

Maybe even lower them to "trace".

Please do this and then we solve 2 things at the same time 👍

  • current PR sqlx debug level don't shows seaorm logs and continue with unreadable log

debug

trace

Copy link
Collaborator

@helio-frota helio-frota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to trace 👍 -- comment added thanks

@helio-frota
Copy link
Collaborator

extra:

solve 2 things at the same time

  1. if we turn off slqx, we will no longer see elapsed = 2.816096ms
  2. with sqlx trace we keep seeing the seaorm and we solve the Backend - Disable sqlx debug log #23

@ctron
Copy link
Contributor Author

ctron commented Mar 8, 2024

@helio-frota I updated the PR.

@bobmcwhirter bobmcwhirter merged commit 208f369 into trustification:main Mar 8, 2024
2 checks passed
@ctron ctron deleted the feature/reduce_loggin_1 branch March 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants