Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable npm lint, as we don't make use of its results right now #28

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Mar 8, 2024

As mentioned in #19 I find it pretty hard to work with PRs because of those unrelated warnings, which show up on every PR. Even though no changes have been made on those files.

My proposal here is to either merge this PR and disable this step for now, until we find some time to fix those warnigns. Or find a switch for "warnings as errors" and fail the build in the case of violations.

Spamming PRs and not using the outcome to improve the code seems counterproductive.

@ctron ctron merged commit 29e90ae into trustification:main Mar 8, 2024
5 checks passed
@ctron ctron deleted the feature/disable_lint_1 branch March 8, 2024 13:13
@helio-frota
Copy link
Collaborator

unrelated warnings

this is one of the reasons I mentioned to move UI to a diff repository

but the reality is that we have more reasons not only in CI bits ( if we want/need to make the thing more professional way )
example: https://github.com/KaotoIO/kaoto-ui/tree/main/.github/workflows

@carlosthe19916
Copy link
Member

unrelated warnings

this is one of the reasons I mentioned to move UI to a diff repository

but the reality is that we have more reasons not only in CI bits ( if we want/need to make the thing more professional way ) example: https://github.com/KaotoIO/kaoto-ui/tree/main/.github/workflows

I agree with you, the UI could live in another repository but perhaps its not the right time yet to do that. We need to collect things like this, see if it makes us slower or faster, what are the things that distract people (e.g. backend should not be distracted by UI work). Eventually evaluate things. Let's be patient in this topic (although I'm not the right person to even mention "patience" as I also need to learn that xD)

@ctron ctron mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants