-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up the full ClearlyDefined definition importer from their blobst… #882
Wire up the full ClearlyDefined definition importer from their blobst… #882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we need both a ClearlyDefinedLoader
taking a Value
and a ClearlyDefinedCurationLoader
taking a Curation
.
I'm not familiar enough with the walker interfaces, so I'll defer to @ctron on that.
The The tl;dr: lazy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things.
} | ||
|
||
pub async fn run(mut self) -> Result<ClearlyDefinedItemContinuation, Error> { | ||
let changes = reqwest::get(self.changes_index_url()).await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates a new connection pool for each request. I think we should create and keep a client.
Same for the other calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will fix
.graph | ||
.ingest_sbom(labels, digests, &curation.document_id(), &curation, &tx) | ||
.await?; | ||
println!("{:#?}", item); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No println
please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh c'mon!
2fd36c5
to
cb678fa
Compare
…ore.