chore: Enhance testing around cyclonedx ingestion #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,7 +134,7 @@ pub async fn get_relationships( | |||
| LEFT JOIN | |||
| sbom_package_purl_ref t2 ON sbom.sbom_id = t2.sbom_id AND t2.node_id = package_relates_to_package.right_node_id | |||
| WHERE | |||
| package_relates_to_package.relationship IN (0, 8, 14) | |||
| package_relates_to_package.relationship IN (0, 1, 8, 14) | |||
There was a problem hiding this comment.
1 = DependencyOf relationship which is how we encode ingesting cyclonedx dependsOn
JimFuller-RedHat
force-pushed
the
cyclonedx-analysis-graph-last
branch
2 times, most recently
from
e9e7543
to
097da94
Compare
JimFuller-RedHat
force-pushed
the
cyclonedx-analysis-graph-last
branch
from
097da94
to
9e267b8
Compare
JimFuller-RedHat
changed the title
JimFuller-RedHat
added
cyclonedx
Vulnerability Correlation
bobmcwhirter
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure (when similarly encoded) that ingestion of cyclonedx matches spdx ingestion.
We also should take care to avoid any race conditions if we encounter sbom that encode circular dependencies.