Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added process diagram & description to GOVERNANCE. #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

a-fox
Copy link
Contributor

@a-fox a-fox commented Nov 14, 2022

Signed-off-by: Antti Kettunen [email protected]

@a-fox a-fox requested a review from talltree as a code owner November 14, 2022 13:29
@a-fox a-fox self-assigned this Nov 14, 2022
@a-fox a-fox requested a review from wenjing as a code owner November 14, 2022 13:29
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: a-fox / name: Antti Kettunen (8526be0)

@a-fox a-fox linked an issue Nov 14, 2022 that may be closed by this pull request
@a-fox a-fox mentioned this pull request Nov 14, 2022
Copy link
Contributor

@andorsk andorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-fox some changes requested. It has to do with the interplay between CONTRIBUTING.md and GOVERNANCE.md files.


## Editorial process
The editorial process diagram below describes how different roles interact with each other and what responsibilities they hold in the writing and updating of the specification. In principle, it's the responsibility of the contributors to raise issues in the specification document, and come up with a new change proposal.
Changes to the specification are done by forking the repository and making the changes first to their own repository, and creating a Pull Request against the original repository. The pull request is then reviewed by one or more editors. Editors may approve the PR directly, or propose additional changes. In case additional discussion is deemed necessary, a new ad hoc group can be formed to work on the issue. Discussion around issues usually happen in the community meetings or in separately agreed group meetings. Once the PR is approved, it is merged by the maintainers of the repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add spacing

7. Merge Pull Request

![ToIP Git process](https://user-images.githubusercontent.com/1370528/201668601-8858a595-80c3-4ee3-8f7c-f2821a890c57.png)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to link to the CONTRIBUTING.md file and reference that for more information. I.e The GOVERNANCE file shouldn't be the law for how to contribute, the CONTRIBUTING file should be I think.

The process stuff I would recommend to move over to the CONTRIBUTING.md file.

@andorsk
Copy link
Contributor

andorsk commented Nov 15, 2022

@a-fox one more comment: does that mean that maintainers are the only ones with merge rights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process flow diagram
2 participants