-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added process diagram & description to GOVERNANCE. #75
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Antti Kettunen <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-fox some changes requested. It has to do with the interplay between CONTRIBUTING.md and GOVERNANCE.md files.
|
||
## Editorial process | ||
The editorial process diagram below describes how different roles interact with each other and what responsibilities they hold in the writing and updating of the specification. In principle, it's the responsibility of the contributors to raise issues in the specification document, and come up with a new change proposal. | ||
Changes to the specification are done by forking the repository and making the changes first to their own repository, and creating a Pull Request against the original repository. The pull request is then reviewed by one or more editors. Editors may approve the PR directly, or propose additional changes. In case additional discussion is deemed necessary, a new ad hoc group can be formed to work on the issue. Discussion around issues usually happen in the community meetings or in separately agreed group meetings. Once the PR is approved, it is merged by the maintainers of the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add spacing
7. Merge Pull Request | ||
|
||
 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to link to the CONTRIBUTING.md file and reference that for more information. I.e The GOVERNANCE file shouldn't be the law for how to contribute, the CONTRIBUTING file should be I think.
The process stuff I would recommend to move over to the CONTRIBUTING.md file.
@a-fox one more comment: does that mean that maintainers are the only ones with merge rights? |
Signed-off-by: Antti Kettunen [email protected]