Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add support for the new Pocket Network Shannon Protocol #81

Merged
merged 16 commits into from
Nov 18, 2024
Merged

Feature/add support for the new Pocket Network Shannon Protocol #81

merged 16 commits into from
Nov 18, 2024

Conversation

jhenriquez
Copy link
Collaborator

@jhenriquez jhenriquez commented Nov 17, 2024 •
edited
Loading

  • Accounts
    • Create from private key
    • Create from recovery seeds
    • Retrieve balance
    • Send transactions (Tokens only)
  • Sign Personal Data
    • Creates a Secp256k1 signature of arbitrary data. However, I haven't gone through the path of receiving a request to sign on the extension.

Missing functionality:

@jhenriquez
WIP - Adds all necessary files and the new protocol service and trans…
4077441 
…action definitions. Also adds the spec with protocol service factory.
@jhenriquez
WIP - Implements create Account methods. Get balance. Get Fee and val…
fc5caf1 
…idate transaction (no validations yet).
@jhenriquez
WIP - Updates lavamoat build to include axios.
98a3900
@jhenriquez
WIP - Corrects test fixtures in order to support getNetworkStatus hel…
95444fe 
…per methods. Missing send transaction and signPersonalData.
@jhenriquez
WIP - Adds shannon transaction object validation schema.
e733870
@jhenriquez
WIP - Installs all unmet peer dependencies.
ec7df4a
@jhenriquez
WIP - Fixes the tests after dependency changes and upgrades. Adds the…
aad4065 
… send transaction implementation for Shannon. (Only send tokens)
@jhenriquez
WIP - Send Transaction Tests Mocks failing.
12a89b1
@jhenriquez
WIP - Update policies. Updates types in the extension to support the …
6e179b7 
…new pocket Shannon where needed. Tested support for standalone accounts.
@jhenriquez
WIP - Adds support for Shannon transactions.Have not been tested with…
2108ed6 
… HD wallets.
@jhenriquez
Adds VaulTeller shannon test suite.
d110dac
@jhenriquez
Adds support for HD wallets on Shannon. Corrects hardcoded ethereum p…
c494ff6 
…rotocol issue and adjusts the tests.
@jhenriquez jhenriquez added the enhancement New feature or request label Nov 17, 2024
@jhenriquez jhenriquez self-assigned this Nov 17, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3265432

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@poktscan/vault-specs Minor
@poktscan/tsconfig Minor
@poktscan/extension Minor
@poktscan/vault Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jorgecuesta jorgecuesta merged commit 15ef995 into main Nov 18, 2024
1 check passed
@jorgecuesta jorgecuesta deleted the feature/add-pokt-shannon-support branch November 18, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgecuesta jorgecuesta jorgecuesta approved these changes

@Alann27 Alann27 Awaiting requested review from Alann27

Assignees

@jhenriquez jhenriquez

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhenriquez @jorgecuesta