Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dockerfile build #4013

Closed
wants to merge 1 commit into from
Closed

fix: Dockerfile build #4013

wants to merge 1 commit into from

Conversation

robtry
Copy link

@robtry robtry commented Sep 6, 2024

Description

Fixed the Dockerfile, which previously failed to build and run tests correctly inside the Docker container. The changes ensure that the Docker environment is properly set up to handle both tasks without errors.

How to test

Build the Docker image using the command docker build -t wallet-core-dev . and verify that it completes without errors.
docker run -i -t wallet-core-dev /bin/bash
./tools/build-and-test

Types of changes

  • Bug fix

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed. (There is another PR in developer repo update docker build docs developer#358 )
  • If there is a related Issue, mention it in the description.

@satoshiotomakan
Copy link
Collaborator

Hi @robtry, the CI has failed. Also we do not have any issue with running docker build command

@robtry
Copy link
Author

robtry commented Sep 6, 2024

So can you run ?
docker build docker/wallet-core --tag wallet-core-dev
docker run -i -t wallet-core-dev /bin/bash

and

cd wallet-core
./tools/build-and-test

I mean the folder docker does not even exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants