Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security]: Revert TON Mnemonic in dev branch #4148

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Dec 3, 2024

Description

Revert TON 24-words specific mnemonic as we identified a security issue - possible DoS due to too strict restrictions of the TON Mnemonic words.
TON team is aware of their bad practice, that they don't follow the standard to generate private key: toncenter/tonweb-mnemonic#13

How to test

Run Rust, C++, iOS, Android, WASM tests
In addition, check master...s/dev-revert-ton-mnemonic - there must not be any changes related to TON

Types of changes

Revert 0b167710b325d299398ca82ef57ee8e630e54633 commit

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Dec 3, 2024

Binary size comparison

➡️ aarch64-apple-ios: 12.30 MB

➡️ aarch64-apple-ios-sim: 12.30 MB

➡️ aarch64-linux-android: 15.82 MB

➡️ armv7-linux-androideabi: 13.50 MB

➡️ wasm32-unknown-emscripten: 11.22 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant