VIT-7220: Migrate away from androidx-security-crypto #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
andersio
force-pushed
the
08-19-vit-7220_migrate_away_from_androidx-security-crypto
branch
from
763b757 to
16d99e7
Compare
andersio
force-pushed
the
08-19-vit-7220_migrate_away_from_androidx-security-crypto
branch
from
a22511a to
905a51d
Compare
andersio
deleted the
08-19-vit-7220_migrate_away_from_androidx-security-crypto
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues:
Android Keystore not reliable across the whole Android OEM ecosystem, where some Googler suggested it is OEM firmware level issues. This in turn affects the reliability of a downstream component like
EncryptedSharedPreferencesin androidx-security-crypto.Google decided to deprecate the androidx-security-crypto library.
This PR migrates away from androidx-security-crypto, and removes the usage of
EncryptedSharedPreferences. ExistingEncryptedSharedPreferenceswould be copied into a newSharedPreferencesin a one-off migration.