Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIT-7291: Request only permissions the host app has declared in their AndroidManifest.xml #163

Merged
merged 1 commit into from
Aug 30, 2024
Merged

VIT-7291: Request only permissions the host app has declared in their AndroidManifest.xml #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...lthConnect/src/main/java/io/tryvital/vitalhealthconnect/VitalPermissionRequestContract.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package io.tryvital.vitalhealthconnect

import android.content.Context
import android.content.Intent
import android.content.pm.PackageManager
import androidx.activity.result.contract.ActivityResultContract
import androidx.health.connect.client.PermissionController
import androidx.health.connect.client.permission.HealthPermission
Expand Down Expand Up @@ -157,7 +158,18 @@ class VitalPermissionRequestContract(
}

private fun permissionsToRequest(): Set<String> {
return manager.permissionsRequiredToWriteResources(this.writeResources) +
val appContext = manager.context.applicationContext
val hostAppPackageInfo = appContext.packageManager.getPackageInfo(
appContext.packageName,
PackageManager.GET_PERMISSIONS,
)

val permissionsDeclaredByHostApp = (hostAppPackageInfo.requestedPermissions ?: emptyArray()).toSet()

// Only request permissions that the host app has declared in their AndroidManifest.xml
return permissionsDeclaredByHostApp.intersect(
manager.permissionsRequiredToWriteResources(this.writeResources) +
manager.readPermissionsToRequestForResources(this.readResources)
)
}
}
Loading