VIT-7518: Exceptions thrown from OkHttp interceptor must be okio.IOException to be deemed recoverable #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ception to be deemed recoverable
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ItachiEU
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHttp deems all exceptions except
okio.IOExceptionto be "unexpected error" and subsequently crashes the app process.This means within OkHttp request interceptors, application errors we introduced — e.g.
VitalJWTError— must be wrapped in aokio.IOExceptionsubclass to be treated as recoverable soft error, and avoid causing a process crash.Also fix the settings screen for not populating the current SDK user ID.