VIT-7771: Fix deprioritized resources not making forward progress in some environments

[andersio]

React Native does not appear to use UIScene.

As a result, the app lifecycle callouts appear to behave quite differently. The appWillEnterForeground callout we expected after appDidFinishLaunching does not happen.

This causes our AppStateTracker to be stuck in state = appLaunching instead of progressing to state = foreground shortly after app launch. This in turn has a knock-on effect on (historical stage) deprioritized resources. In 1.2.0-1.2.10, primary avenue of deprioritised resource re-attempts (scheduleDeprioritizedResourceRetries()) are only allowed to run when state = foreground. This resulted in deprioritized resources having a very high chance of being stuck deprioritized and never re-evaluated.

This PR:

1. schedules a UIApplication.applicationState check one runloop iteration after appDidFinishLaunching.

   • This ensures that AppStateTracker will transition to state = foreground in both UIScene-disabled and UIScene-enabled apps.
   • This in turn ensures that scheduleDeprioritizedResourceRetries() will function as expected for apps w/o scene support, e.g., the main bulk of React Native projects.

2. Expand the scope of resource rescue of scheduleUnnotifiedResourceRescue to include resources stuck in started and deprioritized states.

   • Note that the resource rescue runs irrespective of the AppStateTracker state. So this serves as a secondary avenue to trigger deprioritised resources.

[linear]

VIT-7771 [iOS/RN] Fix deprioritized resources not making forward progress in some environments

[andersio]

• Release 1.2.11 #254
• VIT-7771: Fix deprioritized resources not making forward progress in some environments #253 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andersio and the rest of your teammates on Graphite

[andersio]

Merge activity

• Nov 8, 3:15 PM EST: A user started a stack merge that includes this pull request via Graphite.
• Nov 8, 3:15 PM EST: A user merged this pull request with Graphite.