Skip to content

feat(ecmascript): %TypedArray%.prototype.with #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

yossydev
Copy link
Contributor

@yossydev yossydev marked this pull request as ready for review April 13, 2025 09:07
@yossydev yossydev force-pushed the feat/typedarray-prototype-with branch 2 times, most recently from 5a8ae43 to 719e273 Compare April 13, 2025 09:16
@load1n9 load1n9 self-requested a review April 16, 2025 16:40
load1n9
load1n9 previously approved these changes Apr 16, 2025
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job with the garbage collector stuff

@load1n9 load1n9 requested a review from aapoalas April 16, 2025 16:48
Copy link
Member

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes to be made, and then there's a big point of making the data copying more efficient. That'll need some work.

@yossydev yossydev force-pushed the feat/typedarray-prototype-with branch 7 times, most recently from 192e6a5 to 880408a Compare May 2, 2025 14:13
@yossydev yossydev requested a review from aapoalas May 2, 2025 14:17
Copy link
Member

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues remain. The code overall looks really good with the helper functions <3

@yossydev yossydev force-pushed the feat/typedarray-prototype-with branch from 880408a to 9a86cf0 Compare May 8, 2025 13:50
@yossydev yossydev force-pushed the feat/typedarray-prototype-with branch from 9a86cf0 to de3b5bf Compare May 8, 2025 13:55
@yossydev yossydev requested review from eliassjogreen and aapoalas May 8, 2025 13:56
@yossydev yossydev force-pushed the feat/typedarray-prototype-with branch from de3b5bf to 5c4d33e Compare May 8, 2025 14:20
@yossydev
Copy link
Contributor Author

yossydev commented May 8, 2025

It seems like the results differ between --profile release and --profile dev-fast… 👀

✘ cargo build --profile dev-fast && cargo run --bin test262 --profile dev-fast -- -u
    Finished `dev-fast` profile [optimized + debuginfo] target(s) in 22.57s
    Finished `dev-fast` profile [optimized + debuginfo] target(s) in 0.06s
     Running `target/dev-fast/test262 -u`
Updating the expectations file with 1 unexpected test results.

❯ cargo build --profile release && cargo run --bin test262 --profile release -- -u
    Finished `release` profile [optimized] target(s) in 0.20s
    Finished `release` profile [optimized] target(s) in 0.06s
     Running `target/release/test262 -u`
Updating the expectations file with 1 unexpected test results.

By the way, the test in question is timing out:

❯ cargo build && cargo run --bin test262 eval-test built-ins/Array/prototype/push/S15.4.4.7_A3.js
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.19s
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/test262 eval-test built-ins/Array/prototype/push/S15.4.4.7_A3.js`
Loose mode run:
Running: "${HOME}/target/debug/nova_cli" "eval" "--expose-internals" "--no-strict" "--nogc" "${HOME}/tests/nova-harness.js" "${HOME}/tests/test262/harness/assert.js" "${HOME}/tests/test262/harness/sta.js" "${HOME}/tests/test262/test/built-ins/Array/prototype/push/S15.4.4.7_A3.js"

Test result: Timeout

Is it okay to skip this…?

Copy link
Member

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Real nice work, this really cleaned up a lot of the TA prototype methods related code which is great to see <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants