Syn decode in publisher #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaemonSnake
requested review from
pylebecq,
kinok,
MrYawe,
Ciboulette and
adriencohen
DaemonSnake
force-pushed
the
syn-decode-in-publisher
branch
from
f4ac564 to
a8e74ff
Compare
MrYawe
reviewed
Feb 9, 2025
| @@ -1,6 +1,7 @@ | |||
| defmodule WalEx.Event.Dsl do | |||
| defmacro process_events_async(events, functions) do | |||
| module = hd(__CALLER__.context_modules) | |||
| [_ | _] = __CALLER__.context_modules | |||
There was a problem hiding this comment.
yes, context_modules can be an empty list according to its type
if so this macro should crash
List.first returns a nil value in that case
DaemonSnake
force-pushed
the
syn-decode-in-publisher
branch
from
7c286f0 to
964578e
Compare
Experiment to check if moving decoding in Publisher and outside the main connection server allows to increase its throughput
error:
warning: incompatible types given to Kernel.hd/1:
hd(__CALLER__.context_modules)
given types:
list(atom())
but expected one of:
non_empty_list(term(), term())
typing violation found at:
│
3 │ module = hd(__CALLER__.context_modules)
│ ~
│
└─ lib/walex/event/dsl.ex:3:14: WalEx.Event.Dsl.process_events_async/2
DaemonSnake
force-pushed
the
syn-decode-in-publisher
branch
from
964578e to
c748033
Compare
kinok
approved these changes
Feb 10, 2025
…an receive many messages following erlang doc: > If the process may potentially accumulate a large number of messages in its queue it is recommended to set the flag value to off_heap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move decoding of raw binary messages out of the hot-path
might help reduce walex lag