-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/graph view widget #155
Conversation
hierarchy for a term in graph.
src/app/types.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry about this. My new code formatter automatically formatted this TS file, which is the reason behind these large changes.
Very nice implementation, it's fun to play around with the moving badges.
|
Thanks for the extensive review. I forgot to make this pr a draft since it is still in dev due to the newly requested features.
|
Very nice and quick implementation :) Some feedback (on general usability):
|
Thanks. The first two points, I agree. I will implement those. |
Haha, you're right about the third point and the "water" example. In this case, I think that this type of graph does a good job of representing the complex relationships of water. |
Changes have been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small spelling error. Otherwise ready to go.
I also removed the graph view issue that would have been closed by this PR. Some of the CHEBI requirements mentioned there aren't implemented yet.
🎉 This PR is included in version 2.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This is a basic implementation for the graph view. I could not transfer one feature for removing a node from my implementation in Tib TS since there I did not use useQuery which creates an issue for this feature. The rest is there though.