Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum JDK version back to 8 #36

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Set minimum JDK version back to 8 #36

merged 1 commit into from
Oct 28, 2024

Conversation

tsaarni
Copy link
Owner

@tsaarni tsaarni commented Oct 28, 2024

Set the release to JDK8 to maintain compatibility with older JDKs. The version was previously upgraded to JDK15 to support Ed25519. Running with old version led to an error:

.../lib/src/test/java/fi/protonode/certy/TestCredential.java:52: error: cannot find symbol
import java.security.interfaces.EdECPublicKey;
                               ^
  symbol:   class EdECPublicKey
  location: package java.security.interfaces

This issue only arises when using Ed25519, such as when running the test suite. The JDK release flag can remain at JDK8, allowing the package to be used on JDK8 as long as Ed25519 is not required.

Fixes #34

@tsaarni tsaarni merged commit 8760d6f into main Oct 28, 2024
1 check passed
@tsaarni tsaarni deleted the revert-jdk8 branch October 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding JDK8 support back
1 participant