Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #148 #149

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fixes #148 #149

merged 2 commits into from
Sep 30, 2024

Conversation

L45eMy
Copy link
Contributor

@L45eMy L45eMy commented Sep 30, 2024

Using static late binding to use the overridden constants for file name, extension and mime type.

Fixes #148

@L45eMy L45eMy changed the title Allow overriding file name and mime type constants in subclasses fixes #148 Fixes #148 Sep 30, 2024
Copy link
Owner

@tschoffelen tschoffelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this fix!

@tschoffelen tschoffelen merged commit 019e07e into tschoffelen:master Sep 30, 2024
8 checks passed
@tschoffelen
Copy link
Owner

Released in v2.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong mime type for orders
2 participants