Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Pcb3D /> component #137

Closed
wants to merge 4 commits into from
Closed

Conversation

DrSensor
Copy link
Contributor

close #115

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
3d-viewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 7:29am

@DrSensor
Copy link
Contributor Author

DrSensor commented Feb 1, 2025

seems I broke the tooltip 😅

<CadViewer><board>
  ...
</board></CadViewer>

👆🏽 doesn't highlight and display the tooltip but 👇🏽 display the tooltip

const circuit = new Circuit()
circuit.add(<board>
  ...
</board>)

<CadViewer soup={circuit} />

TODO:

  • bun i -d @react-three/test-renderer

@DrSensor
Copy link
Contributor Author

DrSensor commented Feb 8, 2025

Better to rewrite this as class Pcb3D extends Object3D12 (starting v0.1). It's more maintainable to map circuitJSON into three.js scene-graph. Since you just need to transform one format (circuit.json) into another data format (three.js). Interactivity can be handled in classic way via EventDispatcher.

Prop drilling looks neat at first but over time it's prone to introduce new bug, especially when combined with React diff-then-rerender (VDOM).

Footnotes

  1. Major Issues with SVG Rendering #155

  2. vanilla.js version #149

@DrSensor DrSensor closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Pcb3D /> component
1 participant