feat: Add GLTF model loading support to circuit-json-to-gltf #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements tscircuit/tscircuit#758 by adding comprehensive GLTF loader functionality. Features: - GLTF 2.0 file format parsing with base64 buffer support - Triangle mesh extraction from GLTF primitives - Coordinate system transformation (Y-up to Z-up) - Integration with existing STL/OBJ pipeline - Comprehensive error handling and input validation - Performance caching and optimization - 91 test cases with 1,057 assertions across 13 test files Core Implementation: - lib/loaders/gltf.ts: GLTF parser with buffer decoding - lib/types.ts: GLTFMesh interface integration - lib/converters/circuit-to-3d.ts: Pipeline integration - lib/gltf/geometry.ts: Mesh creation utilities Testing Coverage: - Unit tests: Core parsing, triangulation, edge cases, security - Integration tests: End-to-end workflow validation - Performance tests: Caching and memory efficiency - Error handling: Malformed data and network failures 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Remove optional chaining where arrays are guaranteed to exist - Add non-null assertions for required properties - Fix array access patterns for stricter type checking
- Add global JSX IntrinsicElements declaration for model-viewer - Add @ts-ignore directive to suppress TypeScript error for web component - Ensures TypeScript compilation passes for demo site
lessuselesss
force-pushed
the
feat/gltf-support-clean
branch
from
c5ab658 to
905d23b
Compare
- Add optional chaining for db.pcb_board, db.pcb_component, and db.source_component - Fixes TypeScript errors TS18048 in CI type-check 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
lessuselesss
force-pushed
the
feat/gltf-support-clean
branch
from
905d23b to
b5a9f11
Compare
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Hi @seveibar, I've completed the GLTF loader implementation for tscircuit/tscircuit#758. This PR includes:
I noticed the issue was assigned to @ShiboSoftwareDev, but I had already completed the implementation. Happy to collaborate or hand this off if needed. The implementation is complete and ready for review. Let me know if you'd like any changes! |
|
It's up to @seveibar . Btw you need a cosmos example |
|
Shibo and I did a lot of PRs related to this, so you cant get the full claim, if you remove the claim ill divide the bounty into a claim for shibo and a tip for you Shibo should approve the PR as well imo |
seveibar
requested changes
Sep 23, 2025
| result.positions[i] = (x ?? 0) + translation.x! | ||
| result.positions[i + 1] = (y ?? 0) + translation.y! | ||
| result.positions[i + 2] = (z ?? 0) + translation.z! | ||
| } |
There was a problem hiding this comment.
This entire file was made messy. Remove all the weird optional type stuff. You can assert xyz is defined in a way that doesnt compromise readbility
| shouldFail?: boolean | ||
| errorMessage?: string | ||
| delay?: number | ||
| } |
There was a problem hiding this comment.
We dont mock fetch. Start a static asset server during the test if you need a server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements tscircuit/tscircuit#758 by adding comprehensive GLTF loader functionality to complete the circuit-json-to-gltf pipeline.
This completes the final missing piece of the GLTF support chain:
Features
Implementation Details
Core Files
lib/loaders/gltf.ts: GLTF parser with buffer decoding and triangle extractionlib/types.ts: GLTFMesh interface extending existing mesh patternslib/converters/circuit-to-3d.ts: Integration point for model_gltf_url processinglib/gltf/geometry.ts: Mesh creation utilities following project conventionsTesting Coverage
Data Flow
Test Plan
Related Issues
Closes tscircuit/tscircuit#758
🤖 Generated with Claude Code
/claim #758