Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: give indication that the server has refreshed after you saved #31

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat: give indication that the server has refreshed after you saved #31

merged 2 commits into from
Jan 21, 2025

Conversation

ArnavK-09
Copy link
Collaborator

/claim #27

fix #27

image

@algora-pbc algora-pbc bot mentioned this pull request Jan 20, 2025
Closed
@Anshgrover23 Anshgrover23 requested a review from seveibar January 21, 2025 06:40
Anshgrover23
Anshgrover23 requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArnavK-09 console.log("${relativeFilePath} saved. Applying changes and restarting the server...") can we do something like this.
CC: @seveibar

@seveibar
Copy link
Contributor

@ShiboSoftwareDev is the PoC on this one

ShiboSoftwareDev
ShiboSoftwareDev approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@ShiboSoftwareDev ShiboSoftwareDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, but let's make it say: ${relativeFilePath} saved. Applying changes...

@ArnavK-09
Copy link
Collaborator Author

@ShiboSoftwareDev updated, is this pr valid for merge?

Thanks

@ShiboSoftwareDev ShiboSoftwareDev merged commit 7d7f5b2 into tscircuit:main Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anshgrover23 Anshgrover23 Anshgrover23 requested changes

@ShiboSoftwareDev ShiboSoftwareDev ShiboSoftwareDev approved these changes

@seveibar seveibar Awaiting requested review from seveibar seveibar is a code owner

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

give indication that the server has refreshed after you saved
4 participants
@ArnavK-09 @seveibar @ShiboSoftwareDev @Anshgrover23