-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically refresh import types on update #32
Conversation
Let's see what @seveibar has to say on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DevServer should have a "user-friendly" interface, it probably should handle the type importing etc inside of it.
This is a class people would import to start the DevServer in eg a script, but this refactor would make it so it was dependent on code for type management
I’ve updated the code, and this represents the optimal solution I can provide at this time. I hope you find it useful. Kindly review it and suggest any changes so we can proceed to merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, see comment and also i think we need a test
wrote, tests, implemented class, anything else left to merge? thanks |
/claim #28
Fixes #28