Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically refresh import types on update #32

Merged
merged 18 commits into from
Jan 30, 2025

Conversation

ArnavK-09
Copy link
Collaborator

@ArnavK-09 ArnavK-09 commented Jan 20, 2025

/claim #28

Fixes #28

@ArnavK-09 ArnavK-09 requested a review from imrishabh18 January 23, 2025 18:29
@imrishabh18
Copy link
Member

Let's see what @seveibar has to say on this.

@Anshgrover23 Anshgrover23 requested a review from seveibar January 25, 2025 16:47
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DevServer should have a "user-friendly" interface, it probably should handle the type importing etc inside of it.

This is a class people would import to start the DevServer in eg a script, but this refactor would make it so it was dependent on code for type management

@ArnavK-09
Copy link
Collaborator Author

The DevServer should have a "user-friendly" interface, it probably should handle the type importing etc inside of it.

This is a class people would import to start the DevServer in eg a script, but this refactor would make it so it was dependent on code for type management

I’ve updated the code, and this represents the optimal solution I can provide at this time. I hope you find it useful. Kindly review it and suggest any changes so we can proceed to merge. Thanks!

image

@ArnavK-09 ArnavK-09 requested a review from seveibar January 26, 2025 19:17
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, see comment and also i think we need a test

@ArnavK-09 ArnavK-09 requested a review from seveibar January 28, 2025 15:01
@ArnavK-09
Copy link
Collaborator Author

looking good, see comment and also i think we need a test

wrote, tests, implemented class, anything else left to merge?

thanks

@ArnavK-09 ArnavK-09 requested a review from seveibar January 28, 2025 17:14
@ArnavK-09 ArnavK-09 changed the title feat: import types on server refresh feat: automatically refresh import types on update Jan 28, 2025
@seveibar seveibar merged commit 72ad855 into tscircuit:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import types on server refresh
4 participants