-
Notifications
You must be signed in to change notification settings - Fork 82
repro: unnamed chips receive sequential unnamed_chip fallback names #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@devroy10 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
|
@seveibar the unnamed_chip[*] is actually a feature in the code - a fallback mechanism. |
|
yea so not sure what the issue is |
I was unable to reproduce any cases of the chips being named undefined, I think we might need an exact representation of HENRICH noticed. |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
I think I made a typo in the original PR. It's not "undefined" and "unnamed_chip". Its "undefined_chip" or "unnamed_chip". |
|
But also, now I can't seem to get it to do anything other than "undefined_chip". |
|
btw, this is the bug from the original pr. https://tscircuit.com/Heinrich-XIAO/greenboard |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
repro for #1467