Skip to content

Center origin for 2‑pin parts #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Center origin for 2‑pin parts #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 38 additions & 5 deletions hooks/useSchematicState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,14 +846,25 @@ export function useSchematicState() {
// Load boxes
loadedData.boxes.forEach((b, index) => {
const newId = `loaded-box-${uuidv4()}-${index}`
const totalPinCount =
b.leftPinCount + b.rightPinCount + b.topPinCount + b.bottomPinCount
let type: "chip" | "passive" = "chip"
let isPassiveFromFile = false
let width = 2
let height = GRID_SIZE * 2
let rotation: 0 | 90 | 180 | 270 = 0

// Determine if it's a passive component
if (
if (totalPinCount === 2) {
type = "passive"
isPassiveFromFile = true
width = PASSIVE_BODY_WIDTH
height = PASSIVE_PIN_TO_PIN_DIST
const [p1, p2] = b.pins
const dx = Math.abs(p1.x - p2.x)
const dy = Math.abs(p1.y - p2.y)
rotation = dx > dy ? 90 : 0
} else if (
b.topPinCount === 1 &&
b.bottomPinCount === 1 &&
b.leftPinCount === 0 &&
Expand Down Expand Up @@ -884,8 +895,13 @@ export function useSchematicState() {
// Create pins based on pin counts and positions
const pins: Box["pins"] = []
if (type === "passive") {
pins.push({ id: `pin-${newId}-T0`, side: "top", index: 0 })
pins.push({ id: `pin-${newId}-B0`, side: "bottom", index: 0 })
if (rotation === 90) {
pins.push({ id: `pin-${newId}-L0`, side: "left", index: 0 })
pins.push({ id: `pin-${newId}-R0`, side: "right", index: 0 })
} else {
pins.push({ id: `pin-${newId}-T0`, side: "top", index: 0 })
pins.push({ id: `pin-${newId}-B0`, side: "bottom", index: 0 })
}
} else if (type === "chip") {
// Use the helper function to compute margins from actual pin positions
const computedPins = computePinMarginsFromPositions(b.pins, b)
Expand All @@ -900,6 +916,10 @@ export function useSchematicState() {
if (type === "chip") {
appX = b.centerX - width / 2
appY = -b.centerY - height / 2
} else if (type === "passive" && totalPinCount === 2) {
const [p1, p2] = b.pins
appX = (p1.x + p2.x) / 2
appY = -((p1.y + p2.y) / 2)
}

// Extract number from boxId for counter tracking
Expand Down Expand Up @@ -1218,6 +1238,8 @@ export function useSchematicState() {

loadedData.boxes.forEach((b, index) => {
const newId = b.boxId || `loaded-box-${uuidv4()}-${index}`
const totalPinCount =
b.leftPinCount + b.rightPinCount + b.topPinCount + b.bottomPinCount
let type: "chip" | "passive" = "chip"
let isPassiveFromFile = false
let width = 2
Expand Down Expand Up @@ -1246,6 +1268,12 @@ export function useSchematicState() {
width = PASSIVE_BODY_WIDTH
height = PASSIVE_PIN_TO_PIN_DIST
rotation = 90
} else if (totalPinCount === 2) {
type = "passive"
isPassiveFromFile = true
width = PASSIVE_BODY_WIDTH
height = PASSIVE_PIN_TO_PIN_DIST
rotation = b.leftPinCount + b.rightPinCount === 2 ? 90 : 0
} else {
type = "chip"
isPassiveFromFile = false
Expand All @@ -1263,8 +1291,13 @@ export function useSchematicState() {

const pins: Box["pins"] = []
if (type === "passive") {
pins.push({ id: `pin-${newId}-T0`, side: "top", index: 0 })
pins.push({ id: `pin-${newId}-B0`, side: "bottom", index: 0 })
if (rotation === 90) {
pins.push({ id: `pin-${newId}-L0`, side: "left", index: 0 })
pins.push({ id: `pin-${newId}-R0`, side: "right", index: 0 })
} else {
pins.push({ id: `pin-${newId}-T0`, side: "top", index: 0 })
pins.push({ id: `pin-${newId}-B0`, side: "bottom", index: 0 })
}
} else if (type === "chip") {
for (let i = 0; i < b.leftPinCount; i++)
pins.push({ id: `pin-${newId}-L${i}`, side: "left", index: i })
Expand Down