Add double click handler for schematic components #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
seveibar
reviewed
Sep 20, 2025
lib/components/SchematicViewer.tsx
Outdated
| clickToInteractEnabled, | ||
| isInteractionEnabled, | ||
| showSpiceOverlay, | ||
| ]) |
There was a problem hiding this comment.
too much code in this file (keep things clean, move functionality to separate files appropriately)
seveibar
reviewed
Sep 20, 2025
There was a problem hiding this comment.
looks good, see comment
I think we also need a background color or border sort of highlight on each component to make it clear they're clickable
CC @ShiboSoftwareDev this is relevant for configuring voltage sources for simulation, the user will click to configure
|
I guess he meant highlight/border on hover not all the time |
|
@ShiboSoftwareDev I have update now only highlight on hover 21.09.2025_01.41.54_REC.mp4 |
ShiboSoftwareDev
approved these changes
Sep 20, 2025
seveibar
reviewed
Sep 20, 2025
|
Reviewed, couple issues:
|
|
It's completed in #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update video
21.09.2025_01.41.54_REC.mp4
20.09.2025_22.53.49_REC.mp4
Fix #132
/claim #132